search

OctoMap / octomap_msgs

ROS package to provide messages and serializations / conversion for the OctoMap library
http://www.ros.org/wiki/octomap_msgs
32 stars 53 forks source link

Foxy version #21

Closed tylerjw closed 2 years ago

tylerjw commented 2 years ago

As @Ace314159 stated here: https://github.com/OctoMap/octomap_msgs/pull/20#issuecomment-1231096995

The change I made to make this package work in Rolling does not work on Foxy. Is there a chance we could create a foxy branch without this change?

wxmerkt commented 2 years ago

Is there a reason why this change was required in newer versions of ROS2 but would break in older versions? Was this something captured in a changelog/migration guide for message packages?

Happy to create a foxy branch if that is the only solution to resolve it

tylerjw commented 2 years ago

The change for Rolling/Galactic/Humble is caused by the changes in ROS 2 around include directory ordering for underlays.

wxmerkt commented 2 years ago

Thank you - I created a foxy branch without the change in #20. Do we need a binary release to any of the distros with your change in #20 or does it only affect building from source?

tylerjw commented 2 years ago

@Ace314159 do you mind testing this to confirm if this fixes the problem you experienced?

Ace314159 commented 2 years ago

@tylerjw Yeah I have already started a Windows build on https://github.com/Ace314159/ros2-foxy-windows-packages/runs/8098828859, and it looks like it has succeeded! Thank you!

wxmerkt commented 2 years ago

Great, thank you for the confirmation!