search

Odonno / ReduxSimple

Simple Stupid Redux Store using Reactive Extensions
http://www.nuget.org/packages/ReduxSimple/
MIT License
143 stars 19 forks source link

Reliance on Converto / Newtonsoft.Json #100

Open slimshader opened 2 years ago

slimshader commented 2 years ago

Hi,

I just ported this awesome library to Unity (and works like a charm so far) but was hoping to further remove the dependence on Converto for (IsDeepEqual calls) which in turn depends on outdated version of Newtonsoft.Json. My question: if my state is a record, so I know the comparisons are deep, can this code be simplified to not rely on IsDeepEqual?

Odonno commented 1 year ago

I am glad it works great on Unity.

Since we now have System.Text.Json, I believe we can remove the dependency from Newtonsoft. I will take a look when I have some free time.

th3d0g commented 7 months ago

Any update on this?

Odaimoko commented 3 months ago

Hi @slimshader . Is it possible to share some thoughts on porting to Unity? There are to many allocations in ReduxSimple's implmentation. While this is not a thing in WPF or other platforms, in Unity we tend to minimize heap alloc. So how do you manage to do it?