Allowing ability to observe partial state.

Odonno / ReduxSimple

Simple Stupid Redux Store using Reactive Extensions

http://www.nuget.org/packages/ReduxSimple/

MIT License

143 stars 19 forks source link

Allowing ability to observe partial state. #7

Closed mhusainisurge closed 6 years ago

mhusainisurge commented 6 years ago

This is to implement enhancement #4. I generalized it a bit to allow using any arbitrary selector on the state. This is the my first contribution on Github, so I hope I got everything right. 😃

Odonno commented 6 years ago

@mhusainisurge Ey. Thanks for your first time contribution! I really enjoy seeing someone with interest on this project.

Your code looks good. Will need to update the docs in consequence, it is no a subject on this PR so I don't force you with it. Anyway, if you make the changes on the line return on the file, I'll consider this PR OK and merged it right after.

On the meantime, will figure out why appveyor builds are failing..

Odonno commented 6 years ago

Ok, fixed. Build is now working like expected.

mhusainisurge commented 6 years ago

Thanks for considering my PR. I have implemented the changes requested. Looking forward to more contributions!