OmniLayer / OmniJ

OmniLayer for Java, JVM, and Android
Apache License 2.0
133 stars 89 forks source link

Error with selected inputs for the send transaction #113

Open dexX7 opened 9 years ago

dexX7 commented 9 years ago

From time to time regtests fail due to the transaction input selection. I noticed it for the following test more than once (but rarely):

foundation.omni.test.rpc.reorgs.SendToOwnersReorgSpec
    After invalidating a send to owners transaction, the transaction is invalid
    After invalidating a send to owners transaction, the original balances are restored
    Historical STO transactions are not affected by reorganizations

Historical STO transactions are not affected by reorganizations FAILED
    com.msgilligan.bitcoinj.rpc.JsonRPCStatusException: Error with selected inputs for the send transaction
        at com.msgilligan.bitcoinj.rpc.RPCClient.handleBadResponseCode(RPCClient.java:137)
        at com.msgilligan.bitcoinj.rpc.RPCClient.send(RPCClient.java:106)
        at com.msgilligan.bitcoinj.rpc.RPCClient.send(RPCClient.java:154)
        at com.msgilligan.bitcoinj.rpc.RPCClient.send(RPCClient.java:177)
        at foundation.omni.rpc.OmniClient.omniSendSTO(OmniClient.java:339)
        at foundation.omni.test.rpc.reorgs.SendToOwnersReorgSpec.Historical STO transactions are not affected by reorganizations(SendToOwnersReorgSpec.groovy:167)

Related line: foundation/omni/test/rpc/reorgs/SendToOwnersReorgSpec.groovy#L167

It's not clear to me why exactly. The underlying issue is that the sender has not enough BTC, when trying to send the transaction.

This might be caused, because there is a transaction inbetween with high fees (i.e. many inputs), but I can't really reproduce it in a controlled manner.

Let's keep an eye on it though.