search

OmniLayer / OmniJ

OmniLayer for Java, JVM, and Android
Apache License 2.0
133 stars 89 forks source link

Add activation and trading tests for all-pair trading #124

Closed dexX7 closed 8 years ago

dexX7 commented 8 years ago

This pull request adds tests for the trading of non-Omni pairs.

Once the feature with identifier 8 is active, the distributed token exchange can be used with non-Omni tokens.

During the grace period, the old rules are still in place.

Please note: unfortunally unit prices are no longer nominated in Omni, but instead based on forsale/desired, which is different from our release version.

@msgilligan: currently I simply assume the tests are run with an Omni Core version with the feature and the updated unit price meaning (currently pending as https://github.com/OmniLayer/omnicore/pull/361), but the tests will fail with 0.0.10. What do you suggest to tackle this? Ideally we'd provide compatibility for both versions.

dexX7 commented 8 years ago

I added a minimum version requirement via 96a04287850ff28294200b06ec31c5ce544e4f85 to support both 0.0.10 and 0.0.11. Please let me know, if I should move or refactor.

From my side this submission is good to go.