search

OmniLayer / OmniJ

OmniLayer for Java, JVM, and Android
Apache License 2.0
133 stars 89 forks source link

Ignore currently broken tests #183

Closed msgilligan closed 4 years ago

msgilligan commented 4 years ago

This PR will ignore the tests that are currently broken by PR #182

dexX7 commented 4 years ago

I'm not sure what the benefit of not seeing failing tests would be.

Shouldn't we let them fail, so we can also see, when we fix the underlying issue?

msgilligan commented 4 years ago

I'm not sure what the benefit of not seeing failing tests would be.

Shouldn't we let them fail, so we can also see, when we fix the underlying issue?

I want to release v0.5.10 because Omni Market Cap needs it. If any tests fail, I can't do a normal release. It also stops us from running CI tests on any other changes that we make to OmniJ.

So what I recommend we do is create a branch with these tests re-enabled and work on fixing the remaining two issues (Issue #184 and Issue #185) on that branch. We could even update the Omni Core pull tester to use this new branch.

dexX7 commented 4 years ago

@msgilligan: just to clarify, currently these tests only fail with the experimental 0.20 port or also with the proper release?

msgilligan commented 4 years ago

@msgilligan: just to clarify, currently these tests only fail with the experimental 0.20 port or also with the proper release?

They fail with Omni Core 0.8.2 -- which is what is being used on Travis currently.

msgilligan commented 4 years ago

We can remove 1675c216f7130ce5a966e2503ac16ab45896f8ba from this PR and resubmit.

msgilligan commented 4 years ago

With PR #188 and PR #189 we have better solutions than @Ignore-ing.