search

OneIdentity / IdentityManager.Imx

HTML5 source code for Identity Manager web apps
Other
26 stars 109 forks source link

Mandatory reason check in 'qer\request-history' module switched around #109

Closed NielsDeGroot closed 5 months ago

NielsDeGroot commented 5 months ago

qer\src\lib\request-history\request-action\request-action.service.ts In the following function 'createCdrReason' the outcome 'required' parameter is switched around.

Ex. of calling function without a mandatory reason const reason = this.createCdrReason(); const reason = this.createCdrReason("#LDS#Additional comments about your decision");

private createCdrReason(display: string = '#LDS#Reason for your decision', required: boolean = false): BaseCdr { const column = this.entityService.createLocalEntityColumn({ ColumnName: 'ReasonHead', Type: ValType.Text, IsMultiLine: true, MinLen: required ? 0 : 1, });

DEBUG [main.js:2230] A value for column "ReasonHead" is required

Should be: MinLen: required ? 1 : 0,

Regards, Niels

Mathnstein commented 5 months ago

@NielsDeGroot good catch on backwards logic: Internal bug 445856 created.