OneIdentity / IdentityManager.Imx

HTML5 source code for Identity Manager web apps
Other
26 stars 107 forks source link

Unable to save the changes to a dynamic business role after adding another condition #112

Closed IPG-GillesRusso closed 4 months ago

IPG-GillesRusso commented 4 months ago

After adding another condition in the "Edit Business Role" side sheet I am unable to save the changes. The button to save my new condition is not displayed nor clicklable in any way.

Mathnstein commented 4 months ago

@IPG-GillesRusso could you elaborate on "adding another condition"?

Please give clearer repro steps / screenshots / gifs where applicable so I can pass these on to be worked on if they are legitimate bugs.

IPG-GillesRusso commented 4 months ago

I am going to show you each steps I took until I encountered the problem.

  1. I navigated to the Data Explorer
    image
  2. Choose Business Roles on the side. image
  3. Edit the Business Role and add a condition image
  4. Now I am unable to save my change.
Mathnstein commented 4 months ago

@IPG-GillesRusso to confirm you are referring to the "Memberships" > "Automatic memberships" tab correct?

At least according to your screenshot, the final condition you added would need to have an operator to be valid.

I'm able to replicate the "save button is broken" on boolean conditions, but I cannot replicate the "save button is missing". I'll go ahead and open an internal ticket to look at that.

Feel free to add more context to this closed ticket, a developer will refer back to this comment thread when they start investigating.

Mathnstein commented 4 months ago

Created an internal ticket: 446295

IPG-GillesRusso commented 4 months ago

Yes, exactly thank you very much.

So, I discovered that the issue mainly occurs with conditions that have Boolean values. For example, while checking for external employees. We have investigated the issue a bit and we think the issue originates from the save(); function in the dynamic-role.component of the role-membership module but we were unable to solve the issue.

I also already opened separate tickets for the issues concerning the wep portal with your technical support.

Thank you very much in advance. Von: Cody Griffith @.> Gesendet: Dienstag, 13. Februar 2024 15:38 An: OneIdentity/IdentityManager.Imx @.> Cc: Gilles Russo - IPG @.>; Mention @.> Betreff: Re: [OneIdentity/IdentityManager.Imx] Unable to save the changes to a dynamic business role after adding another condition (Issue #112)

@IPG-GillesRussohttps://github.com/IPG-GillesRusso to confirm you are referring to the "Memberships" > "Automatic memberships" tab correct?

At least according to your screenshot, the final condition you added would need to have an operator to be valid.

I'm able to replicate the "save button is broken" on unary conditions. I'll go ahead and open an internal ticket to look at that.

Feel free to add more context to this closed ticket, a developer will refer back to this comment thread when they start investigating.

— Reply to this email directly, view it on GitHubhttps://github.com/OneIdentity/IdentityManager.Imx/issues/112#issuecomment-1941656151, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3ZL57LXI7ODNIERIRW5LTTYTN3FTAVCNFSM6AAAAABDBG5NROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGY2TMMJVGE. You are receiving this because you were mentioned.Message ID: @.**@.>>