Currently, the variables pH_SinePeriodHours, pH_SineAmplitude, Therm_SineAmplitude, and Therm_SinePeriodHours are visible, but not editable from the Current Data page. The main issue with implementing this is including tests that cover each edge case for switching between different calculation modes.
However, the infrastructure is in place to have these values be editable. Currently, in EthernetServer_TC.cpp, there are variables and case statements set up to receive PUT requests changing the sine period and amplitude. The correct function calls in order would just need to be added after the switch statement around line 220 in this file.
One major problem I ran into while trying to make this work was values randomly going extremely out of bounds, which I also discuss in my draft pull request mentioned at the end of this.
In addition, to stick with setting FunctionTypes implicitly, the function calls within sine switch statements should begin with setting ramp Hours to 0, then setting sine period hours or amplitude, implicitly switching into sine mode. However, if setting either sine value to 0, the last call should be to ramp hours, implicitly switching to ramp mode.
There is many different test cases for switching between different modes that will need to be implemented.
Here is my working sketch on what should happen when each of these values are set.
Target_pH applies to flat, ramp and sine.
if Ramp_hours > 0, we are in ramp mode.
if Ramp_hours == 0, we default to flat
if sine amplitude > 0, we are in sine mode, defaulting to 12 period hours.
if sine amplitude == 0, we switch to ramp mode
sine hours can only be set if amplitude > 0.
if sine hours > 0, we set sine hours
if sine hours == 0, we switch back into ramp mode, using half of the previous period hours as the new ramp hours. This also happens if sine amplitude == 0.
Currently, the variables pH_SinePeriodHours, pH_SineAmplitude, Therm_SineAmplitude, and Therm_SinePeriodHours are visible, but not editable from the Current Data page. The main issue with implementing this is including tests that cover each edge case for switching between different calculation modes.
However, the infrastructure is in place to have these values be editable. Currently, in EthernetServer_TC.cpp, there are variables and case statements set up to receive PUT requests changing the sine period and amplitude. The correct function calls in order would just need to be added after the switch statement around line 220 in this file.
One major problem I ran into while trying to make this work was values randomly going extremely out of bounds, which I also discuss in my draft pull request mentioned at the end of this. In addition, to stick with setting FunctionTypes implicitly, the function calls within sine switch statements should begin with setting ramp Hours to 0, then setting sine period hours or amplitude, implicitly switching into sine mode. However, if setting either sine value to 0, the last call should be to ramp hours, implicitly switching to ramp mode.
There is many different test cases for switching between different modes that will need to be implemented.
Here is my working sketch on what should happen when each of these values are set.
This is my Draft Pull request with my proposed & buggy changes to sine editability: https://github.com/Open-Acidification/TankController/pull/460