search

Open-EO / openeo-geotrellis-extensions

Java/Scala extensions for Geotrellis, for use with OpenEO GeoPySpark backend.
Apache License 2.0
5 stars 3 forks source link

Mask twice #179

Closed EmileSonneveld closed 1 year ago

EmileSonneveld commented 1 year ago

Graph to show how applyDataMask was moved:

flowchart TD
  tileSourcesToDataCube --> |-| applyDataMask
  tileSourcesToDataCube --> rasterRegionsToTiles
  readMultibandTileLayer_L843 --> rasterRegionsToTiles
  rasterRegionsToTiles --> |+| applyDataMask
  readKeysToRasterSources --> |-| applyDataMask
  readMultibandTileLayer_L843 --> readKeysToRasterSources
  readMultibandTileLayer_L279 --> tileSourcesToDataCube
jdries commented 1 year ago

Can we add a test for pixel based masking at load time? Otherwise looks good!

EmileSonneveld commented 1 year ago

There is a def multibandWithSpacetimeMask test that fails when tiles are no longer discarted. I enhanced it by adding a reference image and testing to it.