search

Open-EO / openeo-geotrellis-extensions

Java/Scala extensions for Geotrellis, for use with OpenEO GeoPySpark backend.
Apache License 2.0
5 stars 3 forks source link

Numerical errors when calculating SD? #225

Closed EmileSonneveld closed 6 months ago

EmileSonneveld commented 9 months ago

Looks like some floating point errors, or integer overflow.

.aggregate_temporal(intervals=temporal_extent, labels=[temporal_extent[0]], reducer="sd", dimension="t")

job_id: j-23110872a30f419fb4ace82d03c2cbc8 image image

soxofaan commented 9 months ago

as discussed: check if doing (cube * 1.0).aggregate_temporal(... instead of cube.aggregate_temporal(... can be used as workaround

EmileSonneveld commented 9 months ago

That indeed works. Recalculation here: image

I still feel this might be a nice thing to fix, as the result values are around the same range as the original values and the result may be of the same cellType

soxofaan commented 9 months ago

sure, this has to be fixed, but the good thing is that there is a simple workaround for now

jdries commented 8 months ago

may be fixed as side effect of other celltype issues

jdries commented 6 months ago

@EmileSonneveld should be fixed on dev instances. Please try again and reopen if necessary.