Closed CV-Bowen closed 10 months ago
"When enable the VQUEUE_DEBUG and RPMSG_DEBUG, RPMSG_ASSERT can check the buffer add error." I can not see how VQUEUE_DEBUG impact RPMSG_ASSERT,trace. I missed something?
@arnopo I mean we can check the virtqueue_add_buffer()
return error with RPMSG_ASSERT
when enable VQUEUE_DEBUG
.
Because virtqueue_add_buffer()
can return error only when VQUEUE_DEBUG
is enabled.
@arnopo I mean we can check the
virtqueue_add_buffer()
return error withRPMSG_ASSERT
when enableVQUEUE_DEBUG
. Becausevirtqueue_add_buffer()
can return error only whenVQUEUE_DEBUG
is enabled.
Got it, thanks!
Please remove the reference VQUEUE_DEBUG
in the commit message , at RPMsg level we don't aware of virqueue configuration. we still test the the result ( even if always VQUEUE_SUCCESS
)
@arnopo I mean we can check the
virtqueue_add_buffer()
return error withRPMSG_ASSERT
when enableVQUEUE_DEBUG
. Becausevirtqueue_add_buffer()
can return error only whenVQUEUE_DEBUG
is enabled.Got it, thanks! Please remove the reference
VQUEUE_DEBUG
in the commit message , at RPMsg level we don't aware of virqueue configuration. we still test the the result ( even if alwaysVQUEUE_SUCCESS
)
@CV-Bowen, please update the commit message, then ready to merge
@arnopo Thanks, Done.
Add RPMSG_ASSERT() to rpmsg_virtio_return_buffer() to check the possible virtqueue buffer add error.