search

OpenAMP / open-amp

The main OpenAMP library implementing RPMSG, Virtio, and Remoteproc for RTOS etc
https://www.openampproject.org/
Other
678 stars 278 forks source link

virtio: Fix delete_virtqueues function #527

Closed arnopo closed 8 months ago

arnopo commented 8 months ago

The function should return void. the reason is that vdev->func->delete_virtqueues() is optional and return void.

To be generic we should call virtio_delete_virtqueues in all cases. Then depending on the dispatcher we do nothing or call delete_virtqueues()

Fixes: 7f90610 ("virtio: add create_virtqueues and delete_virtqueues in virtio_dispatch")

arnopo commented 8 months ago

git lint report an false positive error : UC4 Line exceeds max length (89>80): "Fixes: 7f90610 ("virtio: add create_virtqueues and delete_virtqueues in virtio_dispatch")" To ignore as this line is standard to declare fix

arnopo commented 8 months ago

@CV-Bowen please could you have a look to this PR

CV-Bowen commented 8 months ago

@arnopo LGTM