OpenEmu / Gambatte-Core

OpenEmu Core plugin with Gambatte to support Game Boy emulation
GNU General Public License v2.0
8 stars 8 forks source link

Add: Colour Palette Revisions #5

Closed ghost closed 2 years ago

ghost commented 4 years ago
AreaZR commented 3 years ago

@MaddTheSane any thoughts?

ghost commented 2 years ago

@AtariDreams @MaddTheSane I forgot I even had this PR open. Thanks for the merge!

I don't know how realistic this is, but it might be better if it wasn't merged in as-is? As you can see from the frequency of commits, I rethink and tweak this often for personal use. And there's stuff in here now that wasn't there when I first opened the PR and maybe it doesn't make a lot of sense now (fan palettes from deviantart, a palette for a romhack, unused palettes based on BGB, etc.)?

You're welcome to adapt parts that make sense to keep. But I kind of think it shouldn't all be there now in full.

clobber commented 2 years ago

Yeah I agree - reverting now.

stuartcarnie commented 2 years ago

Is it worth considering loading custom palettes as a user feature? I know Commodore 64 emulators like VICE, Frodo and virtual64 all support custom palettes.