OpenGIS / inreach-mapshare

Display Your Live inReach MapShare Data on Your WordPress Site
GNU General Public License v2.0
8 stars 1 forks source link

Feature request... make the table of points collapsible, and configure the intial collapse state #9

Closed mmcc-xx closed 2 days ago

mmcc-xx commented 4 months ago

I'd like to provide more screen real estate for the map. I'm thinking that it would be nice to be able to hide or collapse the table of points, and allow the map to take up the freed up space. It would also be nice to provide a setting for the inital state of the table - visible or collapsed.

Again - I'm happy to work on it, but could use some pointers.

I think this is my last request for now :)

morehawes commented 4 months ago

@mmcc-xx,

I think this is a nice addition also. Please see my comment on your other issue about adding Settings/passing options to the front-end.

See here for an example of adding a button to the Map, which you could use as the basis for an additional button.

jQuery is available, so toggling/sliding of the details should be relatively straightforward.

Please do let me know if you need anything further, happy to help.

Cheers,

Joe

mmcc-xx commented 4 months ago

Hi Joe - thanks for your help on this. Due to time constraints, I don't think I'm going to be able to make this into an actual usable feature for the plugin. For my purposes, just adding this to the end of shortcode.less does what I need it to do:

.inmap-wrap .inmap-info {
    display: none;
}
.inmap-wrap .inmap-map {
    width: 100% !important;
}

This obviously just hides the table of points and gives full width to the map. Perhaps this will be enough info to provide someone else a starting point to make this into something generally usable.

morehawes commented 4 months ago

Hi @mmcc-xx,

Understood and thanks again for the feature request!

I also appreciate you raising the issues you encountered with the build process. When I get time I will look in to improving... or more likely overhauling this and hopefully improving the "developer experience".

I have left some comments on your PR just FYI.

Cheers,

Joe

morehawes commented 4 months ago

Hi @mmcc-xx,

I have added this feature to version 2.0.0 of the plugin, currently available for testing on the staging branch (release notes here).

More information here.

All input greatly appreciated! ✌️

morehawes commented 2 days ago

Added to latest release.