[BUG] - Mods breaking final form graphics in KH2

[tryashtar]

OpenKH Build 708

OpenKH Program Mod Manager

Describe the Bug When applying certain mods, the graphics of the Final Form aerial finisher are broken. I reported this here, but was asked to report here instead: https://github.com/TopazTK/KH-ReFined/issues/133

To Reproduce

1. Apply this mod to KH2 and build
2. Load the game and enter final form
3. Perform a full aerial combo ending with the finisher

Expected behavior Vanilla finisher graphics (correct): https://github.com/TopazTK/KH-ReFined/assets/26075577/af33a8dc-1133-408a-bf9a-6e6c8b5d2ffb

Screenshots Modded finisher graphics (incorrect): https://github.com/TopazTK/KH-ReFined/assets/26075577/fbe022f8-1152-4c05-9f44-462548c87ba3

[Vladabdf]

I have replicated the issue. It only happens in "standard" worlds. The effects play correctly in Timeless River.

I'm not sure it's related to OpenKH though, unless somehow #897 messed things up. I can't imagine any other pull request in recent history would be responsible, as I update my mod manager every time there is an update and did not have this issue as well until 3-4 days ago. I've also been playing on Steam Deck lately and assumed it was a WINE graphic issue, as I also updated my WINE prefix.

[Vladabdf]

@shananas Any ideas? Have you seen this error?

[TopazTK]

I have replicated the issue. It only happens in "standard" worlds. The effects play correctly in Timeless River.

I'm not sure it's related to OpenKH though, unless somehow #897 messed things up. I can't imagine any other pull request in recent history would be responsible, as I update my mod manager every time there is an update and did not have this issue as well until 3-4 days ago. I've also been playing on Steam Deck lately and assumed it was a WINE graphic issue, as I also updated my WINE prefix.

TR is not patched in the mod in question. That is why. Also the mod is not the culprit, as it is just a vanilla-like patch.

[Vladabdf]

Just tested without the mod. The effects now play fine. I think it's the mod.

[TopazTK]

Just tested without the mod. The effects now play fine. I think it's the mod.

It isn't. It's the mod manager not being able to build the mod correctly. Honestly, read the bug report.

[TopazTK]

These are the Final Form assets it uses. It builds all .A.US files this way. However, only Final seems affected.

[Vladabdf]

Genuine accident. Whoops

[shananas]

Pretty sure @Zurphing knows i forget the exact details but you need to patch out of order or something.

https://discord.com/channels/409140906625728532/827187150146764810/1139344668556001352

https://discord.com/channels/409140906625728532/827187150146764810/1139349360090554509

Also why does it provide unedited files vs just the sora hud image since that's what you edit

[shananas]

So basically without editing the code you just need to patch in a different order than it's extracted.

[shananas]

Or I'm pretty sure you can do what I did for my hud mods using binarc to only replace the face and seqd since it seems that's all your touching. Should avoid the custom vs vanilla a.us bs or whatever.