OpenKore / openkore

A free/open source client and automation tool for Ragnarok Online
http://openkore.com
Other
1.29k stars 1.05k forks source link

IRO: RE Update ! #2916

Closed sctnightcore closed 5 years ago

sctnightcore commented 5 years ago

ty jimbit for tables file

dewyslam commented 5 years ago

something wrong

as

sctnightcore commented 5 years ago

@dewyslam

npc store? or vend store?

alisonrag commented 5 years ago

Hmm seems like iRI also started to use 4bytes in nameID

dewyslam commented 5 years ago

@sctnightcore its a vend store

sctnightcore commented 5 years ago

@dewyslam recheck again .

panikim commented 5 years ago

image

something wrong =(

when passing through the portal.

sctnightcore commented 5 years ago

@panikim ok

jimbit76 commented 5 years ago
c4c1n6kr3m1 commented 5 years ago

i don't know why this one is exist, this cause arrow bug?

if ( $args->{switch} eq '0B09' && $item->{type} == 10 ) { # workaround arrow byte bug
    $item->{amount} = unpack("v", substr($args->{itemInfo}, $i+7, 2));
}
c4c1n6kr3m1 commented 5 years ago

item_list does not reset on map_change , iRO (inventory, probably cart too), but reset on map server changed

mohitreddyk commented 5 years ago

Image of Error1

Image of Error2

Fadreus commented 5 years ago

Oh yes, about storage. I heard people are complaining in warpportal Kafra have delay when using it. Either bug or what ever it is, I thought I mention it here.

mohitreddyk commented 5 years ago

They added an extra step to the new Kafra storage which makes you unable to click on other NPC/etc before storage loads in.

alisonrag commented 5 years ago

i don't know why this one is exist, this cause arrow bug?

if ( $args->{switch} eq '0B09' && $item->{type} == 10 ) { # workaround arrow byte bug
  $item->{amount} = unpack("v", substr($args->{itemInfo}, $i+7, 2));
}

Because of bRO and tRO, If is not working in iRO just make a condition to check servers

alisonrag commented 5 years ago

They added an extra step to the new Kafra storage which makes you unable to click on other NPC/etc before storage loads in.

https://github.com/OpenKore/openkore/pull/2903

Just use the latest openkore version

ramochas commented 5 years ago

when map serv fix iro

mohitreddyk commented 5 years ago

They added an extra step to the new Kafra storage which makes you unable to click on other NPC/etc before storage loads in.

2903

Just use the latest openkore version

That was meant to be how the new Ragexe woked. Not plain Openkore, the issues are in the previous comment.

Image of Ragexe

Fadreus commented 5 years ago

They added an extra step to the new Kafra storage which makes you unable to click on other NPC/etc before storage loads in.

Ah, sadly then.. I used to open storage and buy white slim pots or crafting arrows.. They sure like to implement unnecessary stuff rather than fixing bug or give new patch..

LordNoobz commented 5 years ago

how do i fix this? since the recent update, my openkore keeps getting stuck here Capture

can someone point me in the right direction? i tried adding the files you guys changed, it still gets stuck at that point.

shiningowl commented 5 years ago

inventory disappeared after teleport. how to fix it?

AzmodanGod commented 5 years ago

how do i fix this? since the recent update, my openkore keeps getting stuck here Capture

can someone point me in the right direction? i tried adding the files you guys changed, it still gets stuck at that point.

Did you find out how to fix it? because apparently they already told how to do so but we are just not smart enough to know so we get thumb down instead of an answer

Fadreus commented 5 years ago

they already told how to do so

Who? Who is this fake person saying there is a fix already?

we are just not smart enough to know so we get thumb down instead of an answer

If you can understand what is "Draft" and "Pull Request" you won't ask such question and get thumb down.

ramochas commented 5 years ago

How come it take so fking long, rs bot update in 2 hr after patch

Fadreus commented 5 years ago

How come it take so fking long, rs bot update in 2 hr after patch

Why can't it be?

sctnightcore commented 5 years ago

How come it take so fking long, rs bot update in 2 hr after patch

Main reason I'm lazy

bgtest999 commented 5 years ago

@sctnightcore Is there a way to return it to normal use? I support you

gilchan commented 5 years ago

I like to feedback that:

The patch to prevent inventory items clearing after a map change works.

However, the bug of wrong inventory amounts for arrows still remains.

Thanks.

bgtest999 commented 5 years ago

storage is a bug when using it a second time bug

noobbotter09 commented 5 years ago

sorry everyone this is my first time posting here. i have done everything have read here and edited everything you pointed. this was my first problem, which i didn't see in your instructions or maybe missed it. but solved it by reading from your old posts by adding the command lines.

[Sep 27 00:23:45 2019.71] Packet Parser: Unknown switch: 0A95

but still, i can't fix this. inventory

i hope you can help me guys. thanks.

ursaaa commented 5 years ago

cant select character on 4th slot or more

Fadreus commented 5 years ago

@noobbotter09 This is not final fix. In case you didn't see up there it wrote "DRAFT" You wasn't suppose to "fix". Fix only from developer. Player just test.

@ursaaa image Make sure you apply all changes.

If you both is uncertain, just copy the whole files changed rather than copy-paste line by line.

LordNoobz commented 5 years ago

they already told how to do so

Who? Who is this fake person saying there is a fix already?

we are just not smart enough to know so we get thumb down instead of an answer

If you can understand what is "Draft" and "Pull Request" you won't ask such question and get thumb down.

sir Fadreus, i dont know anything about the meaning to the technical lingo you are saying. sorry, i am really a noob at this. i just follow step by step fix guides if there is already. God speed and thank you for being patient with noob people like me and i will await updates like others. thank you again and with sincere appreciation.

jimbit76 commented 5 years ago

Bought a correct item but appear as different item in inventory This is after a map change. Quit bot and buy other item. No error.

https://my.pcloud.com/publink/show?code=XZ7eJRkZPh2yJsAAfWkOAxuSxgRgv5qXAgsk

sctnightcore commented 5 years ago

I will update again next month. ty

bgtest999 commented 5 years ago

What happened? I have the same problem with overlay storage. When using it a second time, I didn't know where to fix it. Other parts seemed to have no problems. But thanks for the news updates

gilchan commented 5 years ago

Feedback:

(1) Applied all patches up to "Clear server type iRO_Renewal"

(2) Errors in inventory persists (as below):

Screenshot (19)_LI

c4c1n6kr3m1 commented 5 years ago
  1. Don't reset items on map_change (Done)
  2. Do reset items on map_changed (Not yet)

that's why you got double items after move different map server

isolah123 commented 5 years ago

Hello, I just passed by and want to say thanks for everyone that develops Openkore, I use Openkore for a while, and now I want to learn. I want to inform that apparently the inventories went gone when used a fly wing or butterfly wing, and this will put a problem for selling items, buying items, or item storage right?. but then I realize that the inventories showed up when the characters relog. is this something unusual? or can we put relog command after using fly wing Butterfly wing etc, thankyou

sctnightcore commented 5 years ago

@c4c1n6kr3m1
no idea with it . if u can fix it . talk to me in IRC .

Nipodemos commented 5 years ago

just found another error in inventory when i was getting guarana candy from npc, kore was showing another item, in my case "Canon Ball" (i had this in inventory)

c4c1n6kr3m1 commented 5 years ago

i can not reproduce @Nipodemos, may be because my char is already on brasilis merge it !!! i think bugs are not relate specific to iRO @alisonrag , bRO/tRO use item_list or not ?

about weird inventory name, i am sure iRO doesn't use new 4 digit nameID but if item added as different name (which already had) than probably item ID doesn't match (because move to different map server, you need to reset/clear your items first)

what if reset/clear items on item_list_start ?, to handle duplicate items , or missmatch ID

    if ( $args->{type} == INVTYPE_INVENTORY ) {
        $char->inventory->onMapChange();
    } elsif ( $args->{type} == INVTYPE_CART ) {
        $char->cart->clear;
    } elsif ( $args->{type} == INVTYPE_STORAGE ) {
        $char->storage->clear;
    }

Wx need to implement item_list ?

alisonrag commented 5 years ago

i can not reproduce @Nipodemos, may be because my char is already on brasilis merge it !!! i think bugs are not relate specific to iRO @alisonrag , bRO/tRO use item_list or not ?

about weird inventory name, i am sure iRO doesn't use new 4 digit nameID but if item added as different name (which already had) than probably item ID doesn't match (because move to different map server, you need to reset/clear your items first)

what if reset/clear items on item_list_start ?, to handle duplicate items , or missmatch ID

  if ( $args->{type} == INVTYPE_INVENTORY ) {
      $char->inventory->onMapChange();
  } elsif ( $args->{type} == INVTYPE_CART ) {
      $char->cart->clear;
  } elsif ( $args->{type} == INVTYPE_STORAGE ) {
      $char->storage->clear;
  }

Wx need to implement item_list ?

bRO/tRO use item_list [4 bytes in nameID and cards changed from 8 bytes to 16]

no need to add in wx interface cause item_list save items on inventoryList/storageList/cartList same as before

make sense to me reset list when it start

c4c1n6kr3m1 commented 5 years ago

@alisonrag, are u saying item_list on bRO behave different compare to iRO ?

iRO only receive item_list when change map server or map loaded but not teleport

alisonrag commented 5 years ago

@alisonrag, are u saying item_list on bRO behave different compare to iRO ?

iRO only receive item_list when change map server or map loaded but not teleport

yep, bRO still receiving after teleport, tRO same as iRO only receive in map-server change

c4c1n6kr3m1 commented 5 years ago

and i don't see u reset the storage before item_list datas , seriously ?

alisonrag commented 5 years ago

and i don't see u reset the storage before item_list datas , seriously ?

bRO and tRO still receive storage_opened, this is where storage is reseted, so to these 2 servers i dont need to do nothing

in tRO i just made a workaround when login and removed the map_change hook, cause they dont use the clean github openkore

mohitreddyk commented 5 years ago

@c4c1n6kr3m1 The error which @Nipodemos says happens often along with the storage duplicating bug. With a duplicated storage adding preexisting items to inventory or trying to rodex shows that they are listed with wrong name.

LordNoobz commented 5 years ago

good sirs, has the bot been fixed? thanks in advance.

Nipodemos commented 5 years ago

@LordNoobz they in progress trying to fix. Please, it is not necessary to ask if it is done, it will be when you see a green circle with a check here saying "Changes approved by somente"

until there, we can only wait

LordNoobz commented 5 years ago

ah. sorry, i did not know. thanks for informing me mr. @Nipodemos. btw, where can i locate this green circle with a check?