search

OpenKore / openkore

A free/open source client and automation tool for Ragnarok Online
http://openkore.com
Other
1.29k stars 1.05k forks source link

IRO: RE Update ! #2916

Closed sctnightcore closed 5 years ago

sctnightcore commented 5 years ago

ty jimbit for tables file

Nipodemos commented 5 years ago

https://www.youtube.com/watch?v=rgbCcBNZcdQ

in the video starts the pull request already green, then it turns purple, which means its done

gilchan commented 5 years ago

Feedback:

Inventory listing seemed to be free of errors when I was using X-kore 1 for a few hours over the last couple of days.

LordNoobz commented 5 years ago

@sctnightcore i read this, #2923 and in this what is @Fadreus referring to? i just want to read what @Fadreus is referring in this https://github.com/OpenKore/openkore/issues/2923#issuecomment-536396332. if you could please point me in the right direction? i just want to read so i dont become a burden to you guys here. i dont want to be a noob forever. XD. i also found this. im reading it now. http://forums.openkore.com/viewtopic.php?f=16&t=212987&p=282375&hilit=timeout+on+map+server#p282375 thanks to @Fadreus for posting this.

mohitreddyk commented 5 years ago

@LordNoobz I'm glad you are trying to learn but most of the veterans here are drained out cuz of people just demanding fixes and not taking some time out to google issues which have already been solved or could be easily applied to their situation.

As of right now if you want your bots to work in a somewhat okay fashion you can click on the "Commits" section at the top to see what they have changed and replace all the files they have changed in your Kore folder (The purple box).

Commits

And for the rest of the people here just asking for if the stuff is fixed yet 1) This whole page is a draft pull request. Which means even they are still working on a fix which works. 2) The box below is some of the problems they are working on. Working 3) Once everything is known to be working, it will be approved

@LordNoobz they in progress trying to fix. Please, it is not necessary to ask if it is done, it will be when you see a green circle with a check here saying "Changes approved by someone"

mohitreddyk commented 5 years ago

I am not sure how much this might help but,

Doing a relog mid conversation with an NPC seems to reliably trigger the bug with an item appearing 2 times in the inventory

sctnightcore commented 5 years ago

I don't have time to find a solution. So I think we should merge.

Fadreus commented 5 years ago

If decide to merge, re-open #2920.

LordNoobz commented 5 years ago

@mohitreddyk 1000% thanks for the very precise and accurate answer. im heading that way now. thanks for pointing me to the right direction. sorry im new to github and im still trying to find my way around this community.

ChrstphrR commented 5 years ago

Tested this PR as it stands, and it does work on iRO.

Can anyone confirm it works without interference on another official server?

Nipodemos commented 5 years ago

@ChrstphrR but what about those issues that some people reported (even me) ? i think those problems still persists, and in iRO image

Fadreus commented 5 years ago

Please don't forget to delete iro_update branch before next maintenance on Thursday and re-open item issue if it gonna take a while.

Nipodemos commented 5 years ago

yeah you right, deleting