Closed OpenOrg-gg closed 2 years ago
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 4 weeks, 1 day from now. Please review their action plans below:
1) shr1ftyy has been approved to start work.
Hello,
I’d be happy to attempt this bounty, and also plan to apply to others for developing Amphora that have not already been taken. I’ve been developing smart contracts for clients for the past year (i.e Sam Forman from sturdy.finance), and am also very familiar with Curve Finance’s locking and gauge voting system at a granular level as I’ve had to work with their governance contracts during my time working with Sam. Although most of the work I’ve done with him is private, I do have some work publicly available on Github that demonstrates my capabilities:
https://github.com/Participes-Finance - Liquidity-as-a-service with NFT-powered veNomics. It incorporates Curve’s fee distribution alongside Solidly’s veNFT locking system and MasterChefV2 staking pools. More details here: https://forum.trondao.org/t/participes-finance-liquidity-as-a-service-with-nft-powered-venomics/4216 https://github.com/Findswap-Github - Uniswap V2 Fork deployed on Findora’s EVM. 2) mul53 has applied to start work _(Funders only: approve worker | reject worker)_.
Hey i have a lot of solidity experience and can help you create this. I have worked on forks on complex projects like compound and also something of interest to your project veCRV token. I can fork the cvxCRV system and voting, I also make sure i write the tests for the additional functional and the code to be well documented. Please check my github for the solidity projects i have worked on
Learn more on the Gitcoin Issue Details page.
Hello I'm working on the locked crv and amphCVX implementation. It appears there are some things that there are certain contracts that are broken and unfinished. I've begun attempting to rectify some of these errors as they are minor. But, I'm afraid that someone from the team may already be working on these, and me making changes to those contracts (i.e Vault.sol, Booster.sol) would just make merging annoying. Should I wait, and expect the team for to fix these issues before I begin working on my bounties?
Hi @Shr1ftyy
My apologies, I expected you'd just make those contracts in isolation and wouldn't be waiting on these fixes. We'll prioritize getting those fixes up so the repo is in a usable state.
All good. I can write them separately and maybe y'all can just merge them later. That's also a good alternative.
Hi @Shr1ftyy compile errors have been fixed - much of this code is still a work in progress but it should compile now :)
Hello again,
I've completed the locked crv implementation. Hope to have the amphCVX implementation finished buy the end of the weekend. Will submit both implementations in one PR once I think I've met the criteria.
Hello, I've completed both bounties, when can I expect the pull request to be merged?
Hello, I've completed both bounties, when can I expect the pull request to be merged?
Hi Shr1ftyy, my apologies, we were trying to find someone to do a second review of the code and it took a bit longer than expected.
I expect to have these reviewed and merged by end of week. Thanks for understanding!
Great. Thanks for the heads up.
Similar to Convex's cvxCRV, Amphora will support a amphCRV.
For this bounty you should fork Convex's cvxCRV system (the cvxCRV contract, the locking contract, and a voting system) and make some minor modifications:
Success Criteria:
A successful bounty will include:
Candidate Selection:
Preference will be given to Gitcoin candidates who have done similar types of work, and who outline the approach they would take in their application.
Preference is also given to candidates (on Gitcoin or not) who have worked with Amphora in the past.
Bounty Payout:
The payout for a successful implementation is $2k.
https://gitcoin.co/issue/29374