OpenPrinting / ps-printer-app

PostScript Printer Application
Apache License 2.0
40 stars 13 forks source link

Duplicated printer-device-id attribute breaks get-printer-attributes response #23

Open zdohnal opened 1 year ago

zdohnal commented 1 year ago

Hi,

I've installed a printer via snapped ps-printer-app and tried to query it via ipptool for available attributes:

$ ipptool -tv ipp://localhost:8000/ipp/print/mytest get-printer-attributes.test
"/usr/share/cups/ipptool/get-printer-attributes.test":
    Get-Printer-Attributes:
        attributes-charset (charset) = utf-8
        attributes-natural-language (naturalLanguage) = en
        printer-uri (uri) = ipp://localhost:8000/ipp/print/mytest
        requested-attributes (1setOf keyword) = all,media-col-database
    Get printer attributes using get-printer-attributes                  [FAIL]
        RECEIVED: 15164 bytes in response
...
        Duplicate "printer-device-id" attribute in printer-attributes-tag group
$ ipptool -tv ipp://localhost:8000/ipp/print/mytest get-printer-attributes.test | grep printer-device-id
       printer-device-id (textWithoutLanguage) = MFG:Hewlett-Packard;CMD:PJL,PML,PCLXL,URP,PCL,PDF,POSTSCRIPT;MDL:HP LaserJet M1536dnf MFP;CLS:PRINTER;DES:Hewlett-Packard LaserJet M1536dnf MFP;MEM:MEM=112MB;COMMENT:RES=600x2;LEDMDIS:USB#ff#04#01;U
        printer-device-id (textWithoutLanguage) = MFG:Hewlett-Packard;CMD:PJL,PML,PCLXL,URP,PCL,PDF,POSTSCRIPT;MDL:HP LaserJet M1536dnf MFP;CLS:PRINTER;DES:Hewlett-Packard LaserJet M1536dnf MFP;MEM:MEM=112MB;COMMENT:RES=600x2;LEDMDIS:USB#ff#04#01;U
    Duplicate "printer-device-id" attribute in printer-attributes-tag group

I was not able to debug further at the moment, I will let you know if I find something.

tangyanli commented 9 months ago

The issue has been fixed at pappl side, related issue: https://github.com/michaelrsweet/pappl/issues/328

tillkamppeter commented 9 months ago

@zdohnal could you test again to ee whether it is actually fixed? Should be so ...