Closed toncijajic closed 7 months ago
@toncijajic I've checked it and I see that for some reason the footer has a hardcoded style att that sets its max-width of 480px.
Could you clarify if this was done on purpose and if we still want to keep this max-width? Or can we get rid of it to give the footer the same width as the rest of the content?
Could you clarify if this was done on purpose and if we still want to keep this max-width? Or can we get rid of it to give the footer the same width as the rest of the content?
@bernattorras not sure, I wasn't handling the initial page launch.
Can we trace the code back to who made it and why?
Can we trace the code back to who made it and why?
This is the commit (from the previous repository) where this max-width
harcoded style was added, but there aren't many details about the change, appart from "moving mega footer to its own feature branch"...
https://github.com/a8cteam51/open-source-initiative/commit/fb06366a5a5313c2850c09c13ff7ea28801a3296
Imo, I don't see any particular reason to keep this limitation, as the only item in that area was the footer credits, and its content was smaller than this restriction (this is probably why the width restriction wasn't identified earlier).
@bernattorras thanks, go ahead and remove the limitation please.
I've added a new sidebar named "Footer - Above credits" to render that text (customizable from Appearance>Widgets) in the footer. I've also removed that max-width limitation.
You can see the changes here: https://open-source-initiative-development.mystagingwebsite.com/
@mdrovdahl @toncijajic Let me know if I can push them into production.
@bernattorras - It looks good to me! Feel free to push it to production, and just let me know when it is done so I can inform the partner.
Done!
Feel free to reopen the issue if anything else is needed!
We need to add a credits segment to the site's footer above the colophon WordPress information.
Details