OpenSourceOrg / dotOrg

Public tracker of opensource.org issues
GNU General Public License v3.0
7 stars 1 forks source link

SugarCalendar - Link not being added to the ics #34

Open ajolo2ky opened 5 months ago

ajolo2ky commented 5 months ago

Description

Setting up an event with a meeting link works but when adding that event to Google or other calendars, the meeting link isn't present there

Steps to reproduce

Sign up for https://opensource.org/events/open-source-ai-definition-town-hall-3 Then click Add to calendar button See the calendar details, the meeting link won't be there (unless added as location, which is the current work around)

What you expected to happen

The meeting link getting populated in the calendar invite

What actually happened

No link gets added to the invite (the one you'll see for location was manually added as a workaround)

nickpagz commented 4 months ago

Hi @ajolo2ky

Since the ICS format doesn't support meeting links, we're thinking the best current option is to automate the workaround and add the link to the location field if it's empty. It's almost ready to go in this PR.

An alternative is not do anything at all, since technically, this isn't really a bug and just a limitation of the ics format.

Let me know what you think.

smaffulli commented 4 months ago

I'd go with the location as I think most calendar applications are using that field anyway.

webmink commented 3 months ago

Putting a URL in the Location field of a Google Calendar appointment is not a good idea. Google tries to treat it as an address and attempts to draw a map. The URL is not clickable by recipients and causes frustration. If there is no Location, the URL should be placed in the Description instead.

nickpagz commented 3 months ago

Going back to the original issue description, I've confirmed the meeting link is only missing on the Google Calendar invite. For the other calendar types, the meeting link is appended to the description, so it already exists. Including it in the location field is a nice to have, but not strictly necessary.

Now, adding it to the location field generally works for all calendars, except when adding it to Google Calendar on a mobile device (tested only on iPhone so far). The meeting link will be stripped from the location field in this case. As such, it would be ideal to also have the meeting link included in the description for Google Calendars. Unfortunately, the Sugar Calendar plugin doesn't do this for the Google Calendar option (handled by a different function than the other calendar types). It's not clear if this is intentional, or a bug. There's also no easy way to hook into this function, and it would have to be modified directly to get it added.

ajolo2ky commented 3 months ago

If that’s the case could you submit this code back to mainstream and work with the team? We don’t want to maintain a separate version

On Fri, 8 Mar 2024 at 08:18 Nicholas Pagazani @.***> wrote:

Going back to the original issue description, I've confirmed the meeting link is only missing on the Google Calendar invite. For the other calendar types, the meeting link is appended to the description, so it already exists. Including it in the location field is a nice to have, but not strictly necessary.

Now, adding it to the location field generally works for all calendars, except when adding it to Google Calendar on a mobile device (tested only on iPhone so far). The meeting link will be stripped from the location field in this case. As such, it would be ideal to also have the meeting link included in the description for Google Calendars. Unfortunately, the Sugar Calendar plugin doesn't do this for the Google Calendar option (handled by a different function than the other calendar types). It's not clear if this is intentional, or a bug. There's also no easy way to hook into this function, and it would have to be modified directly to get it added.

— Reply to this email directly, view it on GitHub https://github.com/OpenSourceOrg/dotOrg/issues/34#issuecomment-1985516304, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSKGHBXUQDAC35RLZSGBMLYXGNAFAVCNFSM6AAAAABBSA5IM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVGUYTMMZQGQ . You are receiving this because you were mentioned.Message ID: @.***>