search

OpenSourceOrg / dotOrg

Public tracker of opensource.org issues
GNU General Public License v3.0
9 stars 1 forks source link

SugarCalendar - title gets displayed twice #35

Closed ajolo2ky closed 7 months ago

ajolo2ky commented 8 months ago

Description

image

Steps to reproduce

No response

What you expected to happen

The title should be displayed only once

What actually happened

It's displayed twice

jonesch commented 8 months ago

The SugarCalendar template file is pulling in both titles, so we added some CSS to hide the first title.

image

@ajolo2ky - have a look and let us know if that's more in line with what you were thinking. Thanks!!

smaffulli commented 8 months ago

why not fix the template so that the code doesn't show two h1 elements?

jonesch commented 8 months ago

why not fix the template so that the code doesn't show two h1 elements? Good question. At first glance yesterday, I thought the Page Titles were part of the plugin. And if we were to edit the plugin, our edits would eventually get overwritten when the plugin updates itself.

After looking a bit deeper, I see the Page Titles on these event pages are handled by the template files. Specifically this line: https://github.com/OpenSourceOrg/dotOrg/blob/main/themes/osi/template-parts/header-featured-image.php#L30

I created a Fork, and then opened a PR to merge the update back here. @ajolo2ky or @smaffulli, not sure if either of you can merge the PR I created - https://github.com/OpenSourceOrg/dotOrg/pull/38

nickpagz commented 7 months ago

I merged #38 as the code was already added on the server. Closing.