search

OpenTransport / gtfs-csv2rdf

Mapping script which transforms GTFS CSV into GTFS RDF (turtle, jsonld or ntriples)
http://vocab.gtfs.org
MIT License
13 stars 7 forks source link

Maybe a error, on the FareAttributes Trasformer #16

Open p4535992 opened 8 years ago

p4535992 commented 8 years ago

Maybe I'm wrong, but this part of the code is correct?

if (data["currency_time"]) {
    this.push({ subject: subject, predicate: "http://schema.org/priceCurrency", object : '"' + data["currency_type"] + '"' });
  }

I'm not seeing the property "currency_time" on the documentation of gtfs. If it's correct perhaps we should add a condition, like this:

if (data["currency_time"] && data["currency_type"]) {
    this.push({ subject: subject, predicate: "http://schema.org/priceCurrency", object : '"' + data["currency_type"] + '"' });
  }
pietercolpaert commented 8 years ago

Indeed! That's a typo! Sorry for the late response. Can you pull request the fix?

p4535992 commented 8 years ago

Sure, i make a pull request on the evening.

P.S. Can you update the homepage url on http://lov.okfn.org/dataset/lov/vocabs/gtfs i'm really interested on that ontology, but i can't find a link to the ontology model.

Greetings.

pietercolpaert commented 8 years ago

You mean include a link to http://vocab.gtfs.org?

p4535992 commented 8 years ago

yes, sorry, i haven't think to search that on github, very stupid me. Greetings.

2016-07-20 13:39 GMT+02:00 Pieter Colpaert notifications@github.com:

You mean include a link to http://vocab.gtfs.org?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenTransport/gtfs-csv2rdf/issues/16#issuecomment-233925416, or mute the thread https://github.com/notifications/unsubscribe-auth/AE9f_KT2wZ2mYmCaj3m3Orov9beabSajks5qXgkBgaJpZM4GrqYy .

pietercolpaert commented 8 years ago

No no, you can leave this open! I will do 2 things here: