Closed wendyyng closed 1 year ago
I see this PR is still in draft status, but it's a simple enough change that I think it can be reviewed now.
Everything builds just fine on my machine. I merged in my latest changes from main (so you have one less task for you to do). Yarn didn't need to delint anything.
Two behaviors I observed that we can chat about in our meeting this morning:
If neither of these are addressable/configurable, that's totally fine, and I approve of this PR as it stands now.
Popup doesn't move with the day in the calendar
You are right, the popup stays put when the window is resized. The example provided by the react-big-calendar
also has the behaviour. I took a look at Google Calendar, and their popups also behave this way.
I also looked at the Issues and PR in react-big-calendar
's GitHub repo. While there are issues and PR related to popup, they are not exactly related to the issues we are having. Just in case if you are interested:
I think for now it seems like there is no quick fix for this.
- "+[x] more" link would be that it would only show me the missing items
"+[x] more" link would only show the missing items
@wendyyng Awesome, thanks for doing that research! Then I agree, this is ready to go.
Proposed changes
This PR resolves the #445 by enabling the
react-big-calendar
to show a popup with all the activities of the selected date when the user clicks '+ more' in the calendar's month view. The activities in the popup are also clickable and show the activity dialog with activity information when clicked.Checklist