OpenTree-Education / rhizone-lms

A learning management system focused on self-reflection.
https://rhi.zone
BSD 3-Clause Clear License
14 stars 7 forks source link

#445 Add popup in Calendar to enable the show more via popup feature in month view #451

Closed wendyyng closed 1 year ago

wendyyng commented 1 year ago

Proposed changes

This PR resolves the #445 by enabling the react-big-calendar to show a popup with all the activities of the selected date when the user clicks '+ more' in the calendar's month view. The activities in the popup are also clickable and show the activity dialog with activity information when clicked.

Checklist

image image

seidior commented 1 year ago

I see this PR is still in draft status, but it's a simple enough change that I think it can be reviewed now.

Everything builds just fine on my machine. I merged in my latest changes from main (so you have one less task for you to do). Yarn didn't need to delint anything.

Two behaviors I observed that we can chat about in our meeting this morning:

If neither of these are addressable/configurable, that's totally fine, and I approve of this PR as it stands now.

wendyyng commented 1 year ago

Popup doesn't move with the day in the calendar

  1. fix: update to current react-overlays to constrain popup within the Month container
  2. Popup repositions to top-left of window on resize. The popup on the month view repositions to top left of window on resize. (Not the issue we have)

I think for now it seems like there is no quick fix for this.

wendyyng commented 1 year ago
  • "+[x] more" link would be that it would only show me the missing items

"+[x] more" link would only show the missing items

seidior commented 1 year ago

@wendyyng Awesome, thanks for doing that research! Then I agree, this is ready to go.