OpenTree-Education / rhizone-lms

A learning management system focused on self-reflection.
https://rhi.zone
BSD 3-Clause Clear License
14 stars 7 forks source link

Change the colour of all day activity in month/week/day/agenda's view of calendar #471

Closed SanazDn closed 1 year ago

SanazDn commented 1 year ago

Expected behaviour

Green colour background for all day activity in the month/week/day/agenda's view

Screen Shot 2022-12-05 at 2 44 46 PM Screen Shot 2022-12-05 at 2 45 31 PM Screen Shot 2022-12-05 at 2 55 25 PM Screen Shot 2022-12-05 at 2 45 03 PM

Actual behaviour

All activities have same colour in month/week/day/agenda's views of calendar

Screen Shot 2022-12-05 at 2 57 25 PM Screen Shot 2022-12-05 at 2 57 33 PM Screen Shot 2022-12-05 at 2 57 43 PM

Steps to reproduce

Define "eventPropGette" as a prop for calendar Set specific colour for all day activities

Details and resources

Here is a link for documentation of "eventPropGette" https://jquense.github.io/react-big-calendar/examples/index.html?path=/docs/props--event-prop-getter

Checklist

wendyyng commented 1 year ago

Personally I prefer using a different colour for all day events.

To avoid having a green background for agenda view, I think you can add currentView !== 'agenda'

One thing I noticed and @seidior mentioned in my issue is that the all day activity is a little bit wider than the other activities: image

daveytech commented 1 year ago

Great work and thank you for the screenshots. The group voted for a colour change but a darker blue. Could you present us with two different options to choose from in a darker blue and share on screenshots?

SanazDn commented 1 year ago

Could you please vote which colour is a better match: 1.

Screen Shot 2022-12-06 at 3 53 57 PM

2.

Screen Shot 2022-12-06 at 3 53 30 PM

3.

Screen Shot 2022-12-06 at 3 51 31 PM

4.

Screen Shot 2022-12-06 at 3 51 00 PM
wendyyng commented 1 year ago

I think I like the first option the most!

veranika-karpava commented 1 year ago

I like the forth one.

daveytech commented 1 year ago

My vote is for the 2nd or 1st one.

rrabinovitch commented 1 year ago

I also vote for the first or second ones (they look quite similar to me)

SanazDn commented 1 year ago

I updated the code and also changed the height for all day activity in the week/day's view of calendar.

Screen Shot 2022-12-07 at 8 34 50 PM Screen Shot 2022-12-07 at 8 35 02 PM
SanazDn commented 1 year ago

All day activities are wider than other activities but which one do you think is more standard?

Screen Shot 2022-12-07 at 10 48 28 PM
wendyyng commented 1 year ago

All day activities are wider than other activities but which one do you think is more standard? Screen Shot 2022-12-07 at 10 48 28 PM

I took a look of the documentation and it seems like it's their default setting that makes the all day events a little bit wider image