search

OpenUserCSS / OpenUserCSS-DeepDark

Host your code in the dark. May the dark be kinder on thine eyes. (openusercss.org dark theme)
GNU General Public License v3.0
11 stars 1 forks source link

Forum needs rewrite #15

Closed RaitaroH closed 6 years ago

RaitaroH commented 6 years ago

Also fix #14.

RaitaroH commented 6 years ago

@tkosamja so yeah, pretty tight with college so this would have to wait for a long time for sure. Too much for my taste. But yeah, just too much on my plate. If you have some time man. ALSO PLEASE update your fork first or make another one. Feel free to delete anything from the forum code. Most of it might be useless (the svg's are fine I think, the notif are fine too, some other crap idk).

Otherwise idk, wait I guess.

RaitaroH commented 6 years ago

@tkosamja @DecentM So in case tk doens't have time (also weird name man, glad I have autofill) should I just remove the forum code for now and update that so the forum at least looks less broken or should I just have it there. Alternatively I could code it as an option in stylus and call it ALFA or something.

Your thoughts.

DecentM commented 6 years ago

I don't think it's necessary to delete the theme if that's what you're talking about. I think it's enough if you add a note in the description.
If you really want to make a prominent notice, you can put a simple bar at the top like this: https://openusercss.org/theme/5a2f819f7c57c751001b49df/%7B%22viewingSource%22%3Atrue%7D

You can also split the theme up to a forum one and a main one to limit the damage (I think you mean this).

RaitaroH commented 6 years ago

Ey, @the-j0k3r if you want to take a jab at this too... be my quest. I have themed "mostly" everything myself. Right now there a LOT of small little issues eveywhere :man_facepalming:

RaitaroH commented 6 years ago

@DecentM Nice too see now this theme is working for the forum again :stuck_out_tongue:

RaitaroH commented 6 years ago

Some stuff to have in mind:

the-j0k3r commented 6 years ago

Ey, @the-j0k3r if you want to take a jab at this too... be my quest. I have themed "mostly" everything myself. Right now there a LOT of small little issues eveywhere man_facepalming

You mean fix your style for openuserCSS?

If so, maybe, IDK I dont use the site, BUT if I were to use it, if there are admin/mod portions and I have no access then I cant style/fix anything there, and I hate leaving crap behind. Similar to my USO dark theme and their admin/mod portions that are unstyled.

RaitaroH commented 6 years ago

@the-j0k3r no problem. I thought you also hosted your themes there.

the-j0k3r commented 6 years ago

I dont at this moment the only userCSS I have https://github.com/style-it-themes/travis-ci-inspired-dark-extended is nearly 500Kb big and too big for USO, if openuserCSS accommodates that I may change my mind.

But again without admin access and styling blindly will be crap.

RaitaroH commented 6 years ago

But again without admin access and styling blindly will be crap.

Admin rights? Yo @DecentM give me brag... admin rights. XD

the-j0k3r commented 6 years ago

Ive already fixed your botched job of the patreon image

RaitaroH commented 6 years ago

@the-j0k3r botched? Seriously? Why should I bother when it works with a filter?

Like seriously? Who cares besides you anyway? XD I know the feeling but there is no point to go in such detail when a simple fix does the job anyway :wink:

the-j0k3r commented 6 years ago

boched, I used a filter too.

capture

yours is the top one, botched hahahaha.

RaitaroH commented 6 years ago

XD I didn't even noticed the cut off. It looks fine from the distance. Do a pull.

the-j0k3r commented 6 years ago

Ill do more fixes Im sure you went lazy in other parts and see...

RaitaroH commented 6 years ago

Ill do more fixes Im sure you went lazy in other parts and see...

low blow, particularly now that its broken. also damn that logo, i never noticed

RaitaroH commented 6 years ago

@DecentM says it's flawless XD. I would say there are more things to be done, joker would say at least 1000 extra lines are needed.

https://forums.openusercss.org/topic/10/openusercss-deepdark/4

the-j0k3r commented 6 years ago

hahahaha dont make me pee my pants.

the-j0k3r commented 6 years ago

@RaitaroH thax for the invite to join, however I must decline for privacy reasons.

a) Im not giving out my mobile phone number to GitHub (Microsoft) or any other company for that matter. b) Im not installing 3rd party spyware apps on my phone to enable 2factor nonsense.

So unless the restricttion of 2fa are laxed I wont be joining thank you and sorry.

My password for GtHub is not 1234 either, thats not how it goes here. :)

DecentM commented 6 years ago

I'm not sure if I'm the dumb one here, but I can't see GitHub asking for phone numbers anywhere. I don't think there is an option to, even if I wanted to link my phone.

Everyone in the org has access to the OUC build stack (internal logs, etc), and I'll expand this for easier development later, so unfortunately 2fa has to stay. There are plenty of open source apps for this, including Authenticator (it supports TOTP, which is what almost all sites use): https://f-droid.org/packages/net.bierbaumer.otp_authenticator/

the-j0k3r commented 6 years ago

To setup 2fa its via sms or download app on phone

capture

@DecentM I understand your position, but from my side I wont sacrifice privacy and I dont truest their security with my personal data, Maybe if I get some cheap throw away, Ill reconsider.

RaitaroH commented 6 years ago

@DecentM Actually I hate the token I need to use... is a huge pain. I would also like to remove the 2fa.

DecentM commented 6 years ago

Since the site handles e-mail addresses, disabling 2fa would be a breach of the GDPR because of the member access I mentioned before.
I have been looking into moving to GitLab though. So far it looks great, so maybe I'll move the main repo there, then I'll be able to disable 2fa on this org.

the-j0k3r commented 6 years ago

Well IDK how youre setup or why you moving to Gitlab would solve the 2fa, seems like theres are portions of your setup that youre sharing and cant setup permission for, that could have been solved here too, but I guess now MS owns GitHub everyone is skittish., Anyway doesnt much matter.

GDPR requires 2fa? Seriously? If this is true then they dont read tech security news at all.

RaitaroH commented 6 years ago

This issue should be closed. The forum them is workable now.

the-j0k3r commented 6 years ago

Good :)

DecentM commented 6 years ago

GDPR requires 2fa? Seriously? If this is true then they dont read tech security news at all.

As far as I know, it doesn't mandate using specific technologies, but rather seeks to ensure that people's private information is protected well. Since I've previously set up federated authentication with GH on the build server, it'd be really unwise to lower security there.

Moving to GitLab will be better, since they have their own build setup, integrated into the platform. Then I can turn off 2fa here.

the-j0k3r commented 6 years ago

Like seriously? Who cares besides you anyway? XD I know the feeling but there is no point to go in such detail when a simple fix does the job anyway wink

@RaitaroH https://www.patreon.com/brand/guidelines Patreon cares :)

The reason why I post this, is only so you are informed in case you werent aware.

IMO these guidelines are to be respected.

Solution 1: Its better to pull their logo and host it on the repo and link the background image, one method is described here https://www.sitepoint.com/why-hosting-your-svgs-is-hard-and-how-to-beat-it/ using GitHub, not necessarily gists but in the theme repo directly.

Soution 2: dont style those portions :)

Personally I would want to avoid any possibility of some unpleasant email, even if it is unlikely.

the-j0k3r commented 6 years ago

Also, I already have some working fixes for v1.0.0 of the website which should be out today sometime.

https://forums.openusercss.org/topic/32/1-0-0-release

https://forums.openusercss.org/topic/26/staging-area