OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

appstore.get_skills_list: check for [] or None return #24

Closed ChanceNCounter closed 3 years ago

ChanceNCounter commented 3 years ago

AbstractAppstore.sync_skills_list() can crash when appstore.get_skills_list() returns [] or None. This is possible due to the use of API calls to retrieve most catalogs.

The known crash occurs on line 6 of the routine, where it attempts to log that a skill has been synced and winds up attempting to concat str + NoneType. The method should perform a null check, log when an appstore returns an empty catalog, and pass on that loop iteration.