Requirements Parsing and Unit Tests

OpenVoiceOS / ovos_skill_manager

skill installer for OVOS

Apache License 2.0

5 stars 6 forks source link

Requirements Parsing and Unit Tests #27

Closed NeonDaniel closed 3 years ago

NeonDaniel commented 3 years ago

Updates requirements parsing to merge requirements from skill.json, manifest.yml, and requirements.txt in priority order Updates existing unit tests and adds more SkillEntry tests

Closes #25 #24

TODO:

[x] ~~Test and handle conflicting dependency versions~~
[x] Test commented lines in requirements
[x] Format git spec'd dependencies with auth_key (Maybe this is installer scope and not SkillEntry)
[x] Update existing references to test case where possible

JarbasAl commented 3 years ago

i assume #10 will be incorporated in this PR ?

NeonDaniel commented 3 years ago

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

JarbasAl commented 3 years ago

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

feels cleaner to do it in a single PR i think, but feel free to push the merge button on #10 if it makes your life easier!

NeonDaniel commented 3 years ago

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

feels cleaner to do it in a single PR i think, but feel free to push the merge button on #10 if it makes your life easier!

I'll pull those commits in here then, easier to test with automation that way

ChanceNCounter commented 3 years ago

Closes #24

edit: i really thought that would link the issue 😮

NeonDaniel commented 3 years ago

Should I increment version in this PR?