search

OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

Fix skill installation from URL #35

Closed NeonDaniel closed 3 years ago

NeonDaniel commented 3 years ago

Adds some bugfixes, logging, and unit tests to address issues encountered when trying to install skills from URLs.

Changelog

Add authorname to SkillEntry generated in skill_entry_from_url Add optional skill_dir param to install_skill_from_url Add optional folder param to install_skill Encapsulate and log errors in building SkillEntry.uuid Add OSM test of install_skill_from_url Add entry.uuid checks to TestSkillEntry Add url to raised GithubInvalidUrl exceptions in utils.py

ChanceNCounter commented 3 years ago

I'm just trusting in the thoroughness of the tests (see #39, apart from edge cases.) Other than that, however, I think the remaining unresolved box above is the only blocker. Otherwise, line by line, looks right, tests pass, and I've confirmed the custom exceptions now print the offending input, which is extremely helpful in the wild.