fix SkillEntry.generate_desktop_file() ConcatErr

OpenVoiceOS / ovos_skill_manager

skill installer for OVOS

Apache License 2.0

5 stars 6 forks source link

fix SkillEntry.generate_desktop_file() ConcatErr #60

Closed ChanceNCounter closed 3 years ago

ChanceNCounter commented 3 years ago

Fix: Because exceptions are raised, skill installation can fail or appear to fail when desktop entry creation is unsuccessful.

ChanceNCounter commented 3 years ago

The desktop entry thing is an @AIIX question afaik

Either way, I think it is indeed out of scope.

JarbasAl commented 3 years ago

it should not be created, we discussed this some time back. Need to add logic to detect the homescreen launcher message in python, if it doesnt exist then dont create file.

can we disable it for now since you are touching this code?

ChanceNCounter commented 3 years ago

yep, added to tasklist