search

OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

Catch and handle missing optional skill files #76

Closed NeonDaniel closed 2 years ago

NeonDaniel commented 2 years ago

Installing skills from git URLs will log errors if manifest.yml and skill_requirements.txt are missing, but most skills don't define these files. This PR handles these exceptions and logs to debug instead of error.

NeonDaniel commented 2 years ago

Tested against neon-core here

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (b9bf79d) into master (ba89385) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   56.38%   56.47%   +0.09%     
==========================================
  Files          33       33              
  Lines        2680     2686       +6     
==========================================
+ Hits         1511     1517       +6     
  Misses       1169     1169
Impacted Files Coverage Δ
ovos_skills_manager/github/__init__.py 69.44% <100.00%> (+0.74%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ebb238...b9bf79d. Read the comment docs.