OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

Clone skill locally instead of multiple GH API Calls #78

Open NeonDaniel opened 2 years ago

NeonDaniel commented 2 years ago

Specifically in install_skill_from_url, it would be more efficient to clone the repository and then parse the SkillEntry from the local directory, rather than multiple calls to Github

JarbasAl commented 2 years ago

any other places where this might make sense? i suppose anything doing more than 1 api call might be worth considering, not in individual methods but in places several methods are called in a row

NeonDaniel commented 2 years ago

Without digging too deeply:

NeonDaniel commented 2 years ago

Just revisiting this, we only need the GH API to tell us which commit we want, everything else can be parsed from the URL or downloaded repository