OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

Add `SkillEntry.from_directory` #81

Closed NeonDaniel closed 2 years ago

NeonDaniel commented 2 years ago

Add local parsing option with unit tests Related bugfixes in SkillEntry to ensure property types

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (c473eb3) into master (ba89385) will increase coverage by 3.77%. The diff coverage is 82.95%.

:exclamation: Current head c473eb3 differs from pull request most recent head 0b92521. Consider uploading reports for the commit 0b92521 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   56.38%   60.15%   +3.77%     
==========================================
  Files          33       34       +1     
  Lines        2680     2718      +38     
==========================================
+ Hits         1511     1635     +124     
+ Misses       1169     1083      -86     
Impacted Files Coverage Δ
ovos_skills_manager/local_skill/__init__.py 70.14% <70.14%> (ø)
ovos_skills_manager/appstores/local.py 65.51% <78.57%> (+37.31%) :arrow_up:
ovos_skills_manager/skill_entry.py 67.23% <83.33%> (+0.87%) :arrow_up:
ovos_skills_manager/github/api.py 42.47% <90.90%> (+10.48%) :arrow_up:
ovos_skills_manager/github/__init__.py 73.41% <100.00%> (+4.71%) :arrow_up:
ovos_skills_manager/github/raw.py 63.89% <100.00%> (+0.10%) :arrow_up:
ovos_skills_manager/github/utils.py 94.01% <100.00%> (ø)
ovos_skills_manager/requirements.py 30.43% <100.00%> (+7.24%) :arrow_up:
...os_skills_manager/appstores/mycroft_marketplace.py 56.89% <0.00%> (-3.45%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1410ef...0b92521. Read the comment docs.

ChanceNCounter commented 2 years ago

@ChanceNCounter any feedback?

Not on a 35-file PR I can't personally test, nope.

JarbasAl commented 2 years ago

you know the files are basically just test skills you can ignore right?