search

OpenVoiceOS / ovos_skill_manager

skill installer for OVOS
Apache License 2.0
5 stars 6 forks source link

Handle Commented requirements files #94

Closed NeonDaniel closed 2 years ago

NeonDaniel commented 2 years ago

Current implementation will fail to install skills that have commented lines in requirements.txt. Technically out-of-spec, but could be easily accounted for

https://github.com/OpenVoiceOS/ovos_skill_manager/blob/067385a42b1cf2dff87b4775fd34886663d137bd/ovos_skills_manager/local_skill/__init__.py#L99

NeonDaniel commented 2 years ago

Looks like this is handled for remote skill entries https://github.com/OpenVoiceOS/ovos_skill_manager/blob/067385a42b1cf2dff87b4775fd34886663d137bd/ovos_skills_manager/github/api.py#L378-L379