search

OrderedSet86 / gtnh-flow

Factory Optimization Flowcharts for Gregtech: New Horizons
MIT License
80 stars 24 forks source link

Name Canonicalization is duplicated and conflicting #49

Closed Hermanoid closed 1 week ago

Hermanoid commented 2 months ago

A recent commit seems to have caused some chaos with name canonicalization. It adds a new system to replace provided names with a canonical version using an Identity Groups system in the __init__.py file - fair enough, but there are two issues with this on main:

  1. It conflicts with/is a duplicate of another canonicalization system here in loadMachines.py
  2. It conflicts with names used in overclock_data.yaml and corresponding names in overclocks.py - by my glance-over, I found "large therminal refinery" (misspelled), 'floation cell regulator' (misspelled), "chem plant" (in overclock_data.yaml it's "chemical plant"), and "cutting factory" ("cutting factory controller"), but I may have missed some.

The name issues can be easily resolved, but I think it would be wise to drop one of these duplicate systems.

OrderedSet86 commented 1 week ago

Great summary, I will work on this now since it seems to be causing issues. Some of the shorter ones are intentional, like chem plant and cutting factory

OrderedSet86 commented 1 week ago

Fixed in https://github.com/OrderedSet86/gtnh-flow/commit/238f72a382af14282d4d37ad3277cc04010551ef