pkluz
commented
7 years ago Please make sure - after merging - to add a PR to this repository: https://github.com/Originate/CocoaPods/tree/master/OriginateTheme exposing the Podspec there as well.
Please add two github issues to this project, namely:
- [x] Break the python script into smaller pieces by extracting the code-snippets into proper template files.
- [x] Add unit tests for the code generation (given static input A expect answer B). Python has
unittestfor this, it should totally suffice.
rweindl
@pkluz @paytonmiller @kevgo This PR tracks the progress on
OriginateThemeversion 1.0.0. The release of the new version is implementing a new concept of dynamically creating access to themes provided in theJSONfiles. After integrating the OriginateTheme framework into a project the specifiedJSONfile will automatically get parsed and via a code generation phase transformed to accessible Objective-C classes. These created or modified classes are added to the OriginateTheme framework before each source code compilation.In addition, it is possible to override theme styles dynamically on runtime by creating a new instance of the
OTThemeobject and providing a path to aJSONfile which overwrites (partially) the at compile time defined styles will be used as fallback. This will allow (remote) customization of the OriginateTheme framework also after submitting or distributing the application.The implementation of the framework is finished, an example project is added, all files are in a state I would submit them for review and a comprehensive documentation inside README file is added. If you want you can already start giving me a review on these files.
Since I still have to implement tests this PR remains with a work in progress label.
Before this branch is merged on master the Podfile in the example folder has to be updated to point to the new created version tag of the .podspec or the Originate .podspec.