search

Ostoic / RaidBrowser

Bringing LFR to Wrath of the Lich King (Non-Classic)
MIT License
36 stars 19 forks source link

Issue with Join message #34

Closed Hasamida closed 1 year ago

Hasamida commented 1 year ago

The "Join" button nor double clicking does not seem to be working for me. I have tried with the Active and specific spec settings on multiple characters. Contrary to the screenshots in the ReadMe section the addon does not even recognise any GS when saving a spec. I am suspecting my gearscore addon not being compatible

Wow_2023-02-05_11-21-35

Ostoic commented 1 year ago

I had a friend run into this problem while setting up their new ElvUI interface. I told them to download Gearscore (since they didn't have it) and that fixed it. However, I believe it shouldn't silently fail like that and would just not provide your gearscore in the join message. Are you using a particular version of the common Gearscore addon, or a different one?

Hasamida commented 1 year ago

I think its a common one

Wow_2023-02-11_14-40-06

Hasamida commented 1 year ago

I've noticed i had escript errors turned off. I am getting the following error when clicking on the join button

Message: Interface\AddOns\RaidBrowser\stats.lua:166: attempt to concatenate local 'gs' (a nil value) Time: 02/11/23 14:54:58 Count: 1 Stack: (tail call): ? Interface\AddOns\Auctionator\AtrErrorInspector.lua:106: in function <Interface\AddOns\Auctionator\AtrErrorInspector.lua:51>

Interface\AddOns\RaidBrowser\stats.lua:166: in function `build_inv_string' Interface\AddOns\RaidBrowser\gui.lua:68: in function <Interface\AddOns\RaidBrowser\gui.lua:63>

Locals: (temporary) = "LeftButton" (temporary) = false (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = defined =C:-1

And i am gettign the following error when clicking on "Save Raid Gear" button:

Message: Interface\AddOns\RaidBrowser\raidset_frame.lua:105: attempt to concatenate local 'gs' (a nil value) Time: 02/11/23 15:22:45 Count: 1 Stack: (tail call): ? Interface\AddOns\Auctionator\AtrErrorInspector.lua:106: in function <Interface\AddOns\Auctionator\AtrErrorInspector.lua:51>

Interface\AddOns\RaidBrowser\raidset_frame.lua:105: in function <Interface\AddOns\RaidBrowser\raidset_frame.lua:96>

Locals: (temporary) = "LeftButton" (temporary) = false (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = defined =C:-1

I have noticed i was getting multiple errors regarding BonusScanner addon which is a part of GearScore. I have downloaded a different version of Gearscore addon which seems to work alot better but i am still getting the same errors in Raid Browser At the moment i am using GS Version 3.1.15 (Release)

Hasamida commented 1 year ago

Today i am getting different set of errors:

`Message: Interface\AddOns\RaidBrowser\raidset_frame.lua:105: attempt to concatenate local 'gs' (a nil value) Time: 02/12/23 13:10:07 Count: 1 Stack: Interface\AddOns\Auctionator\AtrErrorInspector.lua:106: in function <Interface\AddOns\Auctionator\AtrErrorInspector.lua:51>

Interface\AddOns\RaidBrowser\raidset_frame.lua:105: in function <Interface\AddOns\RaidBrowser\raidset_frame.lua:96>

Locals: msg = " Interface\AddOns\RaidBrowser\raidset_frame.lua:105: attempt to concatenate local 'gs' (a nil value)" funcnames =

{ } funcstr = "" looksLikeAuctionatorError = false inAtrErrorHandler = true origErrorHandler = defined Interface\FrameXML\BasicControls.xml::4 zc =
{ msg_red = defined @Interface\AddOns\Auctionator\zcUtils.lua:609 IsEnglishLocale = defined @Interface\AddOns\Auctionator\AuctionatorLocalize.lua:52 msg = defined @Interface\AddOns\Auctionator\zcUtils.lua:738 GetArrayElemOrFirst = defined @Interface\AddOns\Auctionator\zcUtils.lua:150 NumToBool = defined @Interface\AddOns\Auctionator\zcUtils.lua:563 CopyDeep = defined @Interface\AddOns\Auctionator\zcUtils.lua:1004 tallyAdd = defined @Interface\AddOns\Auctionator\zcUtils.lua:1122 ShowHide = defined @Interface\AddOns\Auctionator\zcUtils.lua:36 StringStartsWith = defined @Interface\AddOns\Auctionator\zcUtils.lua:931 msg_color = defined @Interface\AddOns\Auctionator\zcUtils.lua:615 round = defined @Interface\AddOns\Auctionator\zcUtils.lua:603 printmem = defined @Interface\AddOns\Auctionator\zcUtils.lua:1032 StringContains = defined @Interface\AddOns\Auctionator\zcUtils.lua:893 CheckDeferredCall = defined @Interface\AddOns\Auctionator\zcUtils.lua:332 priceToMoneyString = defined @Interface\AddOns\Auctionator\zcUtils.lua:842 tallyPrint = defined @Interface\AddOns\Auctionator\zcUtils.lua:1134 msg_badErr = defined @Interface\AddOns\Auctionator\zcUtils.lua:645 GetArrayElemOrNil = defined @Interface\AddOns\Auctionator\zcUtils.lua:165 BoolToNum = defined @Interface\AddOns\Auctionator\zcUtils.lua:553 If = defined @Interface\AddOns\Auctionator\zcUtils.lua:99 periodic = defined @Interface\AddOns\Auctionator\zcUtils.lua:355 Min = defined @Interface\AddOns\Auctionator\zcUtils.lua:69 msg_pink = defined @Interface\AddOns\Auctionator\zcUtils.lua:610 SetTextIf = defined @Interface\AddOns\Auctionator\zcUtils.lua:47 TrimBrackets = defined @Interface\AddOns\Auctionator\zcUtils.lua:975 msg_str = defined @Interface\AddOns\Auctionator\zcUtils.lua:628 ItemNamefromLink = defined @Interface\AddOns\Auctionator\zcUtils.lua:472 enc64 = defined @Interface\AddOns\Auctionator\zcUtils.lua:215 Val = defined @Interface\AddOns\Auctionator\zcUtils.lua:58 TrimQuotes = defined @Interface\AddOns\Auctionator\zcUtils.lua:955 StringEndsWith = defined @Interface\AddOns\Auctionator\zcUtils.lua:911 printableLink = defined @Interface\AddOns\Auctionator\zcUtils.lua:1019 PrintTable = defined @Interface\AddOns\Auctionator\zcUtils.lua:385 StringSame = defined @Interface\AddOns\Auctionator\zcUtils.lua:875 priceToString = defined @Interface\AddOns\Auctionator\zcUtils.lua:806 PullItemIntoMemory = defined @Interface\AddOns\Auctionator\zcUtils.lua:521 val2gsc = defined @Interface\AddOns\Auctionator\zcUtils.lua:788 PrintKeysSorted = defined @Interface\AddOns\Auctionator\zcUtils.lua:110 msg_ex = defined @Interface\AddOns\Auctionator\zcUtils.lua:747 Negate = defined @Interface\AddOns\Auctionator\zcUtils.lua:573 ClearTable = defined @Interface\AddOns\Auctionator\zcUtils.lua:995 BoolToString = define`

I have disabled it at the error now look like this:

`Message: Interface\AddOns\RaidBrowser\raidset_frame.lua:105: attempt to concatenate local 'gs' (a nil value) Time: 02/12/23 13:13:20 Count: 2 Stack: C: ? Interface\AddOns\RaidBrowser\raidset_frame.lua:105: in function <Interface\AddOns\RaidBrowser\raidset_frame.lua:96>

Locals: `

MassCraxx commented 1 year ago

Had the same problem using and older Gearscore (non-Lite) version. Should be fixed with #39.

While we wait for the merge, feel free to test out the fixed version (alongside some other fixes) beforehand here: https://github.com/MassCraxx/RaidBrowser/tree/dev

Hasamida commented 1 year ago

It seems to be fixed. It loaded the GS and the join message was sent, but it doesnt display anything in the selection window. Might be that the spec name is too long.

image

image

image

image

image

MassCraxx commented 1 year ago

Yes, this is a (minor) bug, will be fixed by #27 but its not included in my dev branch, as this is not my fix. Lets hope @Ostoic finds some time soon to deal with all this =)

Ostoic commented 1 year ago

I'll close this for now and open a new issue for the spec name not showing up in the combo box.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.