OtherwiseJunk / ParanoiaPerfectEditionSystem-foundryvtt

Other
3 stars 2 forks source link

Cant select Roll if notes are more than one line #45

Open zedsupremus opened 4 months ago

zedsupremus commented 4 months ago

Issue: Cant change from brains alpha complex.

Cause: any thing on the naughty side (not caused by gear or objectives) with more than one line of text.

Suggested solution : Switch these boxes (and other big ones) to prose mirror or allow for multiple lines of text.

OtherwiseJunk commented 4 months ago

I can take a look at this this evening! Hopefully have a fix in place before the end of the upcoming weekend

zedsupremus commented 4 months ago

Additional. I may be incorrect on not caused by gear or objectives. That seems to possibly impact as well.

OtherwiseJunk commented 4 months ago

Closed this a little preemptively.

https://github.com/OtherwiseJunk/ParanoiaPerfectEditionSystem-foundryvtt/releases/tag/v0.4.1

@zedsupremus I did some minimal testing around this, but if you could confirm this release fixes your issue when you have the chance that would be great! Seemed to work on my test system but I want to confirm it before the issue gets closed out.

zedsupremus commented 4 months ago

Did some testing

Fixes all the boxes I listed.

However I did more testing.

I'm sorry but Mission Objectives and Gear boxes also have the same issue.

Other boxes no longer cause that issue however.

Apologies for missing them the first time

OtherwiseJunk commented 3 months ago

Hey no worries, sorry it took me so long to get back on this! Should have a fix in place for these last two areas this evening.

OtherwiseJunk commented 3 months ago

Version 0.4.2 is available, hopefully this should fix everything🙏

OtherwiseJunk commented 2 months ago

@zedsupremus sorry for such a long delay, can you confirm if this issue is still happening in the latest version (0.5.1)?

zedsupremus commented 2 months ago

Hey sorry i haven't had a chance to test till now (foundry v12 however)

So, If there is content, they work perfectly so original bug solved!

HOWEVER if there is no content, you can no longer add content. Given a new sheet has content in it, I suspect you may be aware of this.

OtherwiseJunk commented 2 months ago

Yeah I need to better position the edit button, but at least that portion is working.

I'll take some time this weekend to get it buttoned up for previously existing sheets though.