OvercastNetwork / SportBukkit

CraftBukkit and Bukkit modifications that improve stability and add new features
100 stars 85 forks source link

Use ShellBuildTools #142

Closed socram8888 closed 9 years ago

socram8888 commented 9 years ago

So I hadn't noticed SportBukkit was being updated to 1.8, and I started doing it on my own. As the official BuildTools also compiled Spigot and other unnecessary stuff I didn't need, I coded my own shell-based build script.

Now, fast-forward, here's a fork of SportBukkit 1.8 which employs my ShellBuildTools application. ShellBuildTools prepares a CB 1.8 fork ready to be patched. It doesn't compile it, and it doesn't patch or create a Spigot fork. It also offers a more fine-tuned control in CB build process.

Resulting code and patches match 1:1 BuildTools' output (in fact, it uses the very same applications that BuildTools uses under the hood), so there are no compatibility issues or anything.

jedediah commented 9 years ago

Thanks for this, but our plan is to convert SportBukkit to a BuildTools fork, or possibly ShellBuildTools, now that I know it exists. Including it as a submodule adds another layer of complexity to an already nutty build system, and it doesn't quite work anyway because SB patches need to be applied against a specific CB version.

socram8888 commented 9 years ago

Yeah, removing the current patch system will probably ease the update and build process. If you want to apply patches using Spigot's patch system, using SBT you could:

# Initialize SBT submodules
./init.sh
# Prepare remapped NMS and install in local Maven repository
./remap-nms.sh
# Decompile remapped NMS to nms-src
./decompile-nms.sh

Apply patches to CB sources and NMS diffs, then

./apply-nms-patches.sh

And you're set