java.lang.IllegalArgumentException: Invalid locale format

OvercastNetwork / SportBukkit

CraftBukkit and Bukkit modifications that improve stability and add new features

99 stars 84 forks source link

java.lang.IllegalArgumentException: Invalid locale format #187

Closed kailan closed 8 years ago

kailan commented 8 years ago

Player#getCurrentLocale is throwing this error:

java.lang.IllegalArgumentException: Invalid locale format: en-GB
    at org.apache.commons.lang.LocaleUtils.toLocale(LocaleUtils.java:110) ~[sportbukkit-1.9.2-R0.1-SNAPSHOT.jar:git-Bukkit-8bf4588]
    at org.bukkit.craftbukkit.entity.CraftPlayer.getCurrentLocale(CraftPlayer.java:1812) ~[sportbukkit-1.9.2-R0.1-SNAPSHOT.jar:git-Bukkit-8bf4588]

The error occurs when using English (US) or English (UK) locale and I assume all others as well.

TheMolkaPL commented 8 years ago

Should be en_US, not en-US which toLanguageTag() method returns.

kailan commented 8 years ago

I've found the issue – creating a PR now.