OvercastNetwork / SportBukkit

CraftBukkit and Bukkit modifications that improve stability and add new features
99 stars 84 forks source link

Magma blocks don't work #199

Closed Pablete1234 closed 8 years ago

Pablete1234 commented 8 years ago

When a player steps ontop of a magma block (only on survival/adventure mode), the client gets kicked for "Internal server error" (happens with 1.10 and 1.9 clients), also, the new blocks display as air for the 1.9 clients, shouldn't they be something else? (atleast stone or something) image

jedediah commented 8 years ago

It's difficult to replace blocks at the protocol level. Beyond preventing client crashes or exploits, I don't want to do anything special to support new features in old clients. It's up to you to only use features supported by all the clients you allow to connect.

I'll look into the magma block issue.

Pablete1234 commented 8 years ago

@jedediah you replace the structure blocks item with a stone block, to prevent clients from crashing, you should also try to replace the other new blocks with stone (or with one that assembles the texture/features better)

jedediah commented 8 years ago

Items are easy to replace, blocks are much more difficult since chunks are compiled into a byte array when the packet is created.

Pablete1234 commented 8 years ago

@jedediah true, but you should be able to send single blocks changing packet after the player has loaded a chunk or when another player places down a block

jedediah commented 8 years ago

It's not worth the trouble for us to implement that. We're not going to use the new blocks until all players can see them properly.

Pablete1234 commented 8 years ago

@jedediah if you want all clients to see them properly, you can do really hack stuff with 8 armor stands wearing custom player heads with the textures of the new blocks, but that most likely isn't worth the trouble. Just fix magma block issues, and leave the protocol support as it is

jedediah commented 8 years ago

fixed