OvercastNetwork / SportBukkit

CraftBukkit and Bukkit modifications that improve stability and add new features
100 stars 85 forks source link

Fixing nerfed TNT velocity from slab mounting block #206

Closed ryanwarsaw closed 8 years ago

ryanwarsaw commented 8 years ago

Closing this since the network is shutting down in September.

jedediah commented 8 years ago

The problem with slabs is not caused by that patch. Removing the patch happens to make TNT go farther, but it also completely breaks the occlusion mechanic that was working up until 1.8.

kailan commented 8 years ago

Even if his suggested fix wasn't the issue, surely the issue should still be open? It's clearly a problem that needs looking in to.

kailan commented 8 years ago

Thanks – didn't mean to seem hostile but thought it was silly to close it 👍

ghost commented 8 years ago

Please refer to this for more clarification: https://github.com/OvercastNetwork/Issues/issues/2504

ghost commented 8 years ago

@kblanks This problem is in no way related to OCN, Sportbukkit, or PGM as @jedediah said. It is more of a Minecraft bug that has been present since the 1.8.2 update. Reference: OvercastNetwork/Issues#2504

ghost commented 8 years ago

According to my research: When Mojang nerfed TNT in 1.8.0 and 1.8.1 compared to 1.7.10, Cubist made a bug report regarding this issue https://bugs.mojang.com/browse/MC-66089 (The provided cannons had a ladder, fence, and slabs for mounting blocks, yet only the cannons with slabs and fences were affected). When Mojang "resolved the bug" in 1.8.2, only cannons with the fence as a mounting block were fixed (reverted back to 1.7.10 range). Cannons with slabs on the other hand were "un-nerfed", but were still weaker (1.8.2) compared to 1.7.10. TNT on 1.8.2 was supposed to act like 1.7.10 as TNT on slabs were supposed to act similarly between 1.7.10 and 1.8.2, but sadly it did not. A possible reason is that TNT on slabs in 1.7.10 act differently from 1.8.2 when it was supposed to act the same.

I hope this clears things up. As for Sportbukkit 1.10, Cubist did the right thing to patch MC-100260 as it would ruin all of the cannons built on OCN.

ghost commented 8 years ago

Could we reopen this since OCN is not shutting down anymore?

itsmartin commented 8 years ago

@pj1210 we don't need to have this issue open on two separate trackers, we should keep this one closed in favour of https://github.com/OvercastNetwork/Issues/issues/2504.

ghost commented 8 years ago

@itsmartin sure! no problem