search

OvercastNetwork / SportBukkit

CraftBukkit and Bukkit modifications that improve stability and add new features
100 stars 85 forks source link

Waterproof #91

Closed socram8888 closed 10 years ago

socram8888 commented 10 years ago

Basically this prevents ***holes from placing water buckets on End portals to destroy them. It also special-cases Nether portals so existing Redstone circuits which employ buckets to disable them will still work.

This could be probably fixed on the Bukkit side using a plugin, but I feel that being able to break a block as hard as bedrock by placing a water bucket is a bug and should be fixed on the NMS side.

tonybruess commented 10 years ago

Is placing water to destroy an end or nether portal vanilla behavior?

jengel3 commented 10 years ago

@mrapple using water to destroy nether portals is in vanilla, not sure about end portals though.

socram8888 commented 10 years ago

They're both vanilla. However, while nether portals can be relit, end portals cannot. Only an admin with WorldEdit or simmilar can reactivate them. That's why it's so annoying.

This patch changes the behaviour so the buckets do not simply check the solidity of the object as it did before, but employs the same check method that water employs to check if it can flow to a certain block.

tonybruess commented 10 years ago

Is this fixable with a plugin? SportBukkit tries to avoid modifying vanilla behavior.

socram8888 commented 10 years ago

Apparently it is.