search

Own-and-Ship / oas_agent

The Own & Ship Ruby agent
2 stars 0 forks source link

Avoid nil#+ being called in EventCache #33

Closed caius closed 11 months ago

caius commented 11 months ago

Originally reported in #3

Not sure which of these can return nil, but have observed it throwing a TypeError on both Ruby 2.7.5 and Ruby 3.1.4 now from running gem sha 9287b6388abf913f723870ed07819cbe4811ff00.

Implicitly convert everything to a string to stop this happening.

caius commented 11 months ago

Possibly need to handle errors around the event cache better too - the cache erroring out likely shouldn't bring the app down? Will need some careful thought to make sure we're not swallowing bugs inside it though and the cache is never being used.

caius commented 11 months ago

Closing this as we found the root cause in #35