Owyn / HandyImage

browser userscript (extension) which Shows just fullsize Image with hotkeys & without pop-ups on many image-hosting sites
https://greasyfork.org/scripts/109-handy-image
272 stars 58 forks source link

[fix] imagetwist #518

Closed mjolnir870 closed 1 year ago

mjolnir870 commented 1 year ago

Example links to pages with a single image to fullsize: sample link direct link to fullsize

This is with Open images directly with browser checked in the options. It works rarely, but usually the tab crashes:

image

Owyn commented 1 year ago

This is with Open images directly with browser checked in the options.

directly means browser is opening the image, not the script, so script isn't even there to do anything. I can't fix the browser. Check "send report" box and wait for browser devs to fix this (hopefully).

You can just disable the option to fix this problem. Why did you even enable it in the first place?

mjolnir870 commented 1 year ago

You can just disable the option to fix this problem. Why did you even enable it in the first place?

I enabled it because I like viewing the direct image so I can use my own styles for images.

directly means browser is opening the image, not the script, so script isn't even there to do anything. I can't fix the browser. Check "send report" box and wait for browser devs to fix this (hopefully).

Opening the image directly works fine. It's only when it is redirected via this userscript that the tab crashes. That's why I think there is a problem with the userscript. I tested this in an entirely new profile with no other extensions except Tampermonkey and Handy Images.

Owyn commented 1 year ago

I enabled it because I like viewing the direct image so I can use my own styles for images.

what kind of styles? you can use any custom code to do anything or add styles via "custom js" option in the userscript as well

anyway, if your browser is crashing you should at least mention what it is and its version (and it's a nightly(beta) version - crashes are to be expected...)

mjolnir870 commented 1 year ago

Tampermonkey v4.19.6177 Firefox Dev 111.0b1 (64-bit)

This has been happening since Firefox 110, but I didn't report it because it was very intermittent. Now it is constant.

mjolnir870 commented 1 year ago

seems this was a related issue #513

Owyn commented 1 year ago

I don't even know why I added that option and now it's bringing trouble. it would be logical to just get rid of it all together...

but here's the last try to fix it before that.

Owyn commented 1 year ago

I guess the fix didn't help?

mjolnir870 commented 1 year ago

Just tested and tabs haven't crashed yet, so seems like it's working. Before the fix the tab crashed every single time.

selimsum commented 1 year ago

I can confirm that it seems to be working now.

You can just disable the option to fix this problem. Why did you even enable it in the first place?

@Owyn Obviously you deserve to know the reason why some of us enable that option. I enable it because of the difference in DPI scaling.

I've set Windows DPI scaling to 125% and Firefox honors that setting, so I see 25% bigger images when "Open images directly with browser" is enabled. If not enabled, HandyImage displays them without scaling, thus producing smaller images than my liking.

Owyn commented 1 year ago

@selimsumlu that's intentional to show images with original size, since I myself also have 125% windows scaling and images become blurry when overly enlarged for no reason

and when I want them to get bigger - I just resize it with left\middle mouse click (I have option to fit Smaller than window images to screen size when opened btw)

weird 🤔

selimsum commented 1 year ago

I understand that's a personal preference. In my case, I prefer scaling all of them and accept the fact that they will become blurry. I believe that still makes them more enjoyable on my 27" screen and I don't need to get closer to the screen to view details. So thank you for providing that option.