Owyn / HandyImage

browser userscript (extension) which Shows just fullsize Image with hotkeys & without pop-ups on many image-hosting sites
https://greasyfork.org/scripts/109-handy-image
268 stars 58 forks source link

[Suggestion] - About the problem with redgifs #586

Open gabri25ele opened 3 months ago

gabri25ele commented 3 months ago

about the problems with redgif, mime error etc etc On reddit there is a script that work very well, maybe can be implemented on handyimage

// ==UserScript== // @name Redgifs full height video // @match https://www.redgifs.com/watch/* // @grant none // @version 1.0 // @run-at document-start // ==/UserScript== 'use strict';

function addCSS(text) { const el = document.createElement('style'); el.innerHTML = text;

document.documentElement.appendChild(el);

}

addCSS(.previewFeed:has(.Player.Player_isActive){position: fixed;margin: 0;inset: 0;max-width: unset;overflow: hidden;> :not(.Player){display: none}> .Player{height: 100vh;max-height: unset;width: 100%;min-width: 100%;margin: 0;position: relative;.Video-ProgressBar{bottom: 0;transform: translateY(-18px)}video{z-index: 9}}}.App:has(.Player.Player_isActive) :is(.topNav, .ApplicationFooter, .Player-MetaInfo, .Player:not(.Player_isActive)){display: none});

Owyn commented 3 months ago

About the problem with redgifs

What problem?

gabri25ele commented 3 months ago

About the problem with redgifs

What problem?

this problem

sshot-1

to see we need to "reload page normally" like the reddit problem

Owyn commented 3 months ago

can you give an example link?

gabri25ele commented 3 months ago

can you give an example link?

all links in redgif. any. Don't tell me no one noticed. I thought it was a known problem.

Owyn commented 3 months ago

I open redgifs - click any video and it works fine for me

Owyn commented 3 months ago

try disabling other scripts or extensions which may be breaking this, try opening the broken video in a new window and see where it leads to (since it says it's not a video) try checking browser console (ctrl+shift+J) for errors and messages

gabri25ele commented 3 months ago

I notice two problems:

1) If I go in https://new.reddit.com/r/NSFWFunny and click on any redgifs link,

reddd

I receive the error https://github.com/Owyn/HandyImage/issues/586#issuecomment-2061097204

2) If I go to https://www.redgifs.com > EXPLORE and click on any gif... I see, ok, but no full-windows and Handyimage is NOT ACTIVE

Owyn commented 3 months ago

Check your handyimage settings that you don't have any risky settings enabled such as "directly open images" image

gabri25ele commented 3 months ago

none of this I keep getting errors with links like this https://www.redgifs.com/watch/staidmodernpipistrelle

If you want try a CLEAN Firefox portable, which I'm using for testing, you can download it here, I simply installed the script and added the two in the bookmark bar https://file.io/snkS4rjaH76q

Owyn commented 3 months ago

You can get a clean firefox profile on your current browser while keeping your original one by launching firefox.exe -p to bring up profile manager, I've just created a fresh profile and tested - it works with just tampermonkey extension and this script and nothing else changed in the browser

изображение try clicking right mouse and "inspect element" on the broken video elements and see what the address is, it's supposed to be like this

gabri25ele commented 3 months ago

I made a clean Firefox for you, to see what I see 😁

for me It worked once, then it didn't work again

err

try my Firefox and see what I see

Owyn commented 3 months ago

the video url is definitely wrong there, try the new script version - it now waits for the video to load before grabbing it

gabri25ele commented 3 months ago

nothing changed, I see the image (not in full window) for a few seconds and then error as before. why you don't want to see my Firefox portable. I also wasted time creating it. maybe the problem is there.

Owyn commented 3 months ago

It's not the firefox which is different but the website's content

try clicking "Inspect" on the video element when the script is not running (disable it or press R after it ran) and see what's inside, for me it's a normal address, for you it's a blob:... for some reason

изображение

the new script version should solve this by avoiding such video urls to grab

gabri25ele commented 3 months ago

ok, now I see, but... but... simple view, not only gif at full-window as if handy image was disabled one

due

Owyn commented 3 months ago

handy image was disabled

it doesn't activate since there is no proper video to grab and use (else there'd be that error you've seen), only a :blob for some reason for you, maybe redgifs does that for visitors from your country now, you could try Chrome to confirm it's not browser related

gabri25ele commented 3 months ago

see this, https://krakenfiles.com/view/ocpwhWlXv6/file.html it activate random one time after many refresh

I don't know, work better the other script, with that I see how it should be. sdfsfsdf

Owyn commented 3 months ago

if you mean the style script above - yea, there's no reason it wouldn't work - it removes everything around the video without changing anything unlike here

and this script creates a whole new page (to avoid nasty ads and pop-ups), I can't think of a way to fix this right now