search

OxfordDemSci / ICS_Analysis

Mixed methods approach and interactive dashboard to analyse research impact through Impact Case Studies submitted to the UK's Research Excellence Framework (REF) 2021.
https://shape-impact.co.uk
GNU General Public License v3.0
5 stars 0 forks source link

"Country" to clean list of ISO-3 country codes #11

Closed doug-leasure closed 1 year ago

doug-leasure commented 1 year ago

@bz-dev made a great start converting the messy country names to ISO-3 country codes. I applied their function to the file ./data/edit/clean_ref_ics_data.xlsx but there are still quite a few country names being missed.

I added a TODO note here: https://github.com/OxfordDemSci/ICS_Analysis/blob/drl/src/data_wrangling/2_enrich_data/23_ics.py#LL204C5-L204C5

The error messages returned when you run the line of code (above) provide a comprehensive list of the Country values currently being missed that could be converted to ISO-3 country codes.

@yifan-lu-300, is this something that you have already made progress with?

yifan-lu-300 commented 1 year ago

Yes Doug. Thanks for pointing this out! I'll have a look and correct the country names.

doug-leasure commented 1 year ago

Hey @yifan-lu-300 , I see now that you have already done work here which mostly addresses this issue! Sorry... I'm still catching up on all your good work :)

Please simply use your .toml to add a "Countries_clean" column to the ICS data here.

doug-leasure commented 1 year ago

resolved with PR #10