search

P1sec / pysctp

SCTP stack for Python
http://www.p1sec.com
165 stars 67 forks source link

CI/CD publishing to PyPi #43

Closed domi007 closed 1 year ago

domi007 commented 2 years ago

Hi Benoit,

I have seen you already started with CI/CD publishing of pycrate wheel to pypi. Thank you very much for that! I was wondering if you would be open to do it for this project as well? It would be much more convenient to have the binary wheels on pypi instead of just the source code, so server installation could be simplified (no need to maintain local builds or install gcc and headers onto servers). I would be happy to contribute a simplified CI/CD yaml file for this project based on what you have in pycrate (https://github.com/P1sec/pycrate/blob/master/.github/workflows/cicd.yml), but it would still need your token to Pypi set in this project, so first I wanted to know if you would be open to support this? Simplified would mean: rip out everything there is for Windows and Mac (?) because AFAIR pysctp is Linux only, and adjust tests etc.

Thanks, Domi

p1-bmu commented 2 years ago

Thanks for your proposal Domi. As far as I understand, we would have to build several binary packages, 1 per Python version (3.6, 3.7, 3.8...) x 1 per Linux version (or at least each time there is an API change). I am not sure exactly how much packages we would end with... If you have some github integration config that you think will be OK, feel free to submit a PR, and we'll see with the people at P1 if / how we can integrate it. If this works, it would also benefit to us. Regarding the Windows / Mac integration, I believe this was relying on https://www.sctp.de/sctp.html, which was exposing an API equivalent to the Linux one. But I am clearly not a Mac user and am not aware of the current status: I'll ask around me if their are some Mac users doing SCTP, and how. Regards Benoit

domi007 commented 2 years ago

Thanks Benoit. I think starting with Linux and CPython builds is already a major step forward, so I took the liberty and created a PR for your review: PR #44

domi007 commented 2 years ago

Let me know if there are any issues with the PR, or you decided internally in P1 against it. If you want to see the resulting wheels check the artifacts in my fork (scroll to the bottom): https://github.com/domi007/pysctp/actions/runs/3157404746

p1-bmu commented 2 years ago

Thanks Domi. I've been busy in the last weeks but will manage to integrate the PR and packaging. In the meantime, I could not get a single feedback on SCTP running on Mac, so I guess we can just ignore this part.

p1-ra commented 2 years ago

Hi Domi,

Your PR has been integrated, kudos and thanks for it!