search

PDAL / python

PDAL's Python Support
Other
117 stars 35 forks source link

Cleanups #103

Closed gsakkis closed 2 years ago

gsakkis commented 2 years ago

Miscellaneous cleanups and minor fixes; commit messages are self-explanatory.

hobu commented 2 years ago

Aren't PKG-INFO and tox.ini needed for wheel generation and pip installs? Python is moving away from setup.py, and we want to make sure pip install PDAL does the right thing for people.

gsakkis commented 2 years ago

tox.ini is a config for tox which is not used anymore; the related pytest config has moved to the GH action or removed (for not showing warnings). PKG-INFO is autogenerated by python setup.py sdist; the removed PKG-INFO was not in sync with setup.py.

There is indeed a move away from setup.py to setup.cfg but I'm not sure if/how it works with scikit-build. In any case setup.py is not going away for the foreseeable future (or ever).

Just tried installing the branch in a fresh conda env with PDAL and it works fine:

$ mamba create -n py3.8 python=3.8 pdal
$ conda activate py3.8
$ pip install git+https://github.com/TileDB-Inc/python.git@cleanups
$ python -c "import pdal; print(pdal.Pipeline.mro())"
[<class 'pdal.pipeline.Pipeline'>, <class 'pdal.libpdalpython.Pipeline'>, <class 'pybind11_builtins.pybind11_object'>, <class 'object'>]